Multisig join never resolves

[daviddm]

I've made a test where I try to add a third member to a already existing multisig with 2 members.
When the third member tries to join the multisig the join-operation never resolves.

4b7bd58#diff-4b7bd582572785ca7f073ccab8064051e5b42ef6

[2byrds]

From our keri dev meeting, Provenant along with @pfeairheller recently added two people to their 'migrated' wallet (command line to signify/keria). Signifypy has a series of scripts to test this functionality (for the migration). Provenant did use signify-ts for the two new participants. This was a delegated multi-sig that required approval.
Supplying versions is helpful in order to determine where the fix is needed.
Possibly a signify-ts update has the fix. Or an improvement in the steps used.
Join functionality specifically.

[Sotatek-HocNguyena]

Hi @daviddm. Were you able to call the groups().join? When I called it, it threw me a "500 Internal Server Error" everytime.

[daviddm]

I updated the test and made a PR with it #258

When running the tests the member that tries to join the multisig-group is able to do it and can add the agent end-role after "successful" join. However the join operation still does not resolve.

I'm not sure if something has changed since February, but I know that i didn't try to just disregard the operation status and continue as if it was successful.

So maybe this isn't a signify-ts issue but instead a keria issue?

When printing the join-operation it looks like this
{ name: 'group.EOXbjvZfhXMoTsT48d8IKFXFwU-7QwL4dEd8avBhGfl3', metadata: { sn: 0 }, done: false, error: null, response: null }
What seems weird is that the sequence number is 0, when the groups current sequence number is 2.
It seems hardcoded in keria for joining
https://github.com/WebOfTrust/keria/blob/421716684229195a33287dab3f6556a01b4f8df9/src/keria/app/grouping.py#L144
But example rotating it uses the serders sequence number
https://github.com/WebOfTrust/keria/blob/421716684229195a33287dab3f6556a01b4f8df9/src/keria/app/aiding.py#L598

Versions

Keria: 0.1.3
Signify-ts: latest-main fddaff2

[2byrds]

Thank you for the additions! I'll be taking a look at this next week if it hasn't been addressed by then

[lenkan]

I tried fixing that line and run against a local keria image, then it resolves. WebOfTrust/keria#236

[lenkan]

When the test here passes, we can merge that and this issue is resolved. Currently that test is failing because it the KERIA images is not updated to include the fix.

[2byrds]

@daviddm can this be closed now per #258 ?

[lenkan]

@2byrds Yes, thanks for notifying.