Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/del rot smid rmid tests #254

Merged
merged 22 commits into from
Jun 22, 2024

Conversation

2byrds
Copy link
Collaborator

@2byrds 2byrds commented Jun 13, 2024

Catches KERIA up with KERIpy changes AND provides all functionality necessary for SIGNIFY-TS integration tests to pass, especially multisig-vlei-issuance but also fixes for rotation, salty, and delegation

2byrds added 16 commits June 3, 2024 08:21
…sed credentialing design for IdentifierResource end usage

Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Copy link

codecov bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 92.70073% with 20 lines in your changes missing coverage. Please review.

Project coverage is 93.06%. Comparing base (18d3ad7) to head (76d9a54).
Report is 1 commits behind head on main.

Files Patch % Lines
src/keria/app/aiding.py 83.00% 17 Missing ⚠️
src/keria/app/grouping.py 80.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #254   +/-   ##
=======================================
  Coverage   93.06%   93.06%           
=======================================
  Files          36       36           
  Lines        7121     7198   +77     
=======================================
+ Hits         6627     6699   +72     
- Misses        494      499    +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@2byrds 2byrds requested review from m00sey and pfeairheller June 14, 2024 16:42
@2byrds 2byrds marked this pull request as ready for review June 14, 2024 16:42
@2byrds
Copy link
Collaborator Author

2byrds commented Jun 20, 2024

There is a small amount of overlap with https://github.com/WebOfTrust/signify-ts/pull/234/files but we'll adjust once either is merged.

src/keria/app/aiding.py Outdated Show resolved Hide resolved
src/keria/app/delegating.py Outdated Show resolved Hide resolved
src/keria/app/aiding.py Outdated Show resolved Hide resolved
src/keria/app/aiding.py Outdated Show resolved Hide resolved
@2byrds
Copy link
Collaborator Author

2byrds commented Jun 22, 2024

@pfeairheller I have made all the updates based on your review. I also added a small change to grouping.py to address @daviddm issue and corresponding PR which contains an additional signify-ts test (WebOfTrust/signify-ts#258) that will now pass and can be merged after this.

I also ran against all original singify-ts integration tests again:
image

@pfeairheller pfeairheller merged commit 2acb618 into WebOfTrust:main Jun 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants