-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/test del rot multisig more #267
Fix/test del rot multisig more #267
Conversation
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
… multisig member 2 failing on acceptMultisig exchange Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
In draft until WebOfTrust/keria#254 is merged and a KERIA dev tag release is created. |
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
==========================================
+ Coverage 83.74% 83.82% +0.07%
==========================================
Files 47 48 +1
Lines 4215 4229 +14
Branches 1022 1034 +12
==========================================
+ Hits 3530 3545 +15
+ Misses 681 656 -25
- Partials 4 28 +24 ☔ View full report in Codecov by Sentry. |
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I have added some questions.
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
@2byrds Because of the IPEX PR and revert (with passing build), the integration tests (and compose) should be pointed to https://github.com/2byrds/signify-ts/blob/fix/test_del_rot_multisig_more/.github/workflows/main.yml#L60 |
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
@iFergal i'd prefer to explicitly define what version of KERIA that we've tested with and also avoid any issues with changes in 'latest'. So in this case i'm setting it to 0.2.0-dev3. |
@2byrds Even better, agreed! You can also update the default image tag in the docker compose for those running the tests locally - it's still at |
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Many fixes to bring signify-ts up-to-date with the latest keripy/keria dev releases including fixes for integration tests:
Here is output from a local integration run: