Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/test del rot multisig more #267

Merged
merged 51 commits into from
Jul 26, 2024

Conversation

2byrds
Copy link
Contributor

@2byrds 2byrds commented Jun 14, 2024

Many fixes to bring signify-ts up-to-date with the latest keripy/keria dev releases including fixes for integration tests:

  • Serder changes per keripy
  • Rotation fixes
  • Delegation fixes
  • Salty id fixes
  • more

Here is output from a local integration run:
image

2byrds added 15 commits May 29, 2024 04:38
… multisig member 2 failing on acceptMultisig exchange

Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
@2byrds
Copy link
Contributor Author

2byrds commented Jun 14, 2024

In draft until WebOfTrust/keria#254 is merged and a KERIA dev tag release is created.

@2byrds
Copy link
Contributor Author

2byrds commented Jun 14, 2024

Test results with docker-compose that points to new KERIA:
image

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.82%. Comparing base (e7aaf3c) to head (fe262d4).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #267      +/-   ##
==========================================
+ Coverage   83.74%   83.82%   +0.07%     
==========================================
  Files          47       48       +1     
  Lines        4215     4229      +14     
  Branches     1022     1034      +12     
==========================================
+ Hits         3530     3545      +15     
+ Misses        681      656      -25     
- Partials        4       28      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docker-compose.yaml Outdated Show resolved Hide resolved
Copy link
Collaborator

@lenkan lenkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I have added some questions.

examples/integration-scripts/delegation-multisig.test.ts Outdated Show resolved Hide resolved
examples/integration-scripts/delegation-multisig.test.ts Outdated Show resolved Hide resolved
src/keri/app/exchanging.ts Show resolved Hide resolved
src/keri/app/exchanging.ts Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
src/keri/app/credentialing.ts Show resolved Hide resolved
examples/integration-scripts/salty.test.ts Show resolved Hide resolved
2byrds added 2 commits July 16, 2024 14:54
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
@iFergal
Copy link
Contributor

iFergal commented Jul 16, 2024

@2byrds Because of the IPEX PR and revert (with passing build), the integration tests (and compose) should be pointed to latest again since this seems to be the dev tag now.

https://github.com/2byrds/signify-ts/blob/fix/test_del_rot_multisig_more/.github/workflows/main.yml#L60
https://github.com/2byrds/signify-ts/blob/fix/test_del_rot_multisig_more/docker-compose.yaml#L29

@2byrds
Copy link
Contributor Author

2byrds commented Jul 17, 2024

@2byrds Because of the IPEX PR and revert (with passing build), the integration tests (and compose) should be pointed to latest again since this seems to be the dev tag now.

https://github.com/2byrds/signify-ts/blob/fix/test_del_rot_multisig_more/.github/workflows/main.yml#L60 https://github.com/2byrds/signify-ts/blob/fix/test_del_rot_multisig_more/docker-compose.yaml#L29

@iFergal i'd prefer to explicitly define what version of KERIA that we've tested with and also avoid any issues with changes in 'latest'. So in this case i'm setting it to 0.2.0-dev3.

@2byrds 2byrds marked this pull request as ready for review July 17, 2024 13:07
@iFergal
Copy link
Contributor

iFergal commented Jul 17, 2024

@2byrds Even better, agreed! You can also update the default image tag in the docker compose for those running the tests locally - it's still at 0.1.3

@2byrds 2byrds requested a review from lenkan July 17, 2024 16:02
@2byrds 2byrds mentioned this pull request Jul 18, 2024
test/app/delegating.test.ts Show resolved Hide resolved
test/app/delegating.test.ts Outdated Show resolved Hide resolved
src/keri/app/credentialing.ts Show resolved Hide resolved
examples/integration-scripts/delegation-multisig.test.ts Outdated Show resolved Hide resolved
examples/integration-scripts/utils/multisig-utils.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@rodolfomiranda rodolfomiranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rodolfomiranda rodolfomiranda merged commit 850af59 into WebOfTrust:main Jul 26, 2024
8 checks passed
lenkan added a commit to lenkan/signify-ts that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants