-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multisig join operation never resolves #236
Conversation
Test error seems unrelated:
|
The TraitCodex and MacOS problem are now fixed on main, please rebase to pick them up |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #236 +/- ##
==========================================
- Coverage 93.08% 92.82% -0.27%
==========================================
Files 38 37 -1
Lines 7002 6982 -20
==========================================
- Hits 6518 6481 -37
- Misses 484 501 +17 ☔ View full report in Codecov by Sentry. |
Perfect. Looks like the branch protection rule needs updating after the build changes. I commented in #237. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Attempt to fix issue reported here: WebOfTrust/signify-ts#227
With this change, the commented out steps here: https://github.com/WebOfTrust/signify-ts/pull/255/files#diff-6a2529a7963a536ba8e1b3c7f9c22eddeba360f49bdbc140a039df692ffc168aR366-R367 resolves.