Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: multisig join operation never resolves #236

Merged
merged 1 commit into from
May 6, 2024

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Apr 30, 2024

@lenkan
Copy link
Collaborator Author

lenkan commented Apr 30, 2024

Test error seems unrelated:

ImportError while importing test module '/home/runner/work/keria/keria/tests/app/test_credentialing.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/app/test_credentialing.py:[15](https://github.com/WebOfTrust/keria/actions/runs/8896850173/job/24430429603?pr=236#step:6:16): in <module>
    from keri.core.eventing import TraitCodex, SealEvent
E   ImportError: cannot import name 'TraitCodex' from 'keri.core.eventing' (/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/keri/core/eventing.py)

@lenkan lenkan changed the title fix: multisig join operatoin never resolves fix: multisig join operation never resolves Apr 30, 2024
@pfeairheller
Copy link
Member

The TraitCodex and MacOS problem are now fixed on main, please rebase to pick them up

@lenkan lenkan force-pushed the fix-multisig-join branch from e462af2 to 836b83a Compare May 1, 2024 07:23
@lenkan lenkan force-pushed the fix-multisig-join branch from 836b83a to caad67b Compare May 1, 2024 07:24
Copy link

codecov bot commented May 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.82%. Comparing base (5f06007) to head (caad67b).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #236      +/-   ##
==========================================
- Coverage   93.08%   92.82%   -0.27%     
==========================================
  Files          38       37       -1     
  Lines        7002     6982      -20     
==========================================
- Hits         6518     6481      -37     
- Misses        484      501      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan
Copy link
Collaborator Author

lenkan commented May 1, 2024

Perfect.

Looks like the branch protection rule needs updating after the build changes. I commented in #237.

Copy link
Collaborator

@2byrds 2byrds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@2byrds 2byrds merged commit b74d5cc into WebOfTrust:main May 6, 2024
5 checks passed
@lenkan lenkan deleted the fix-multisig-join branch May 6, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants