Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify prettier setup #223

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Feb 24, 2024

This setup uses an "opt-out" approach through a .prettierignore file rather than the "opt-in" approach.

Some benefits:

I added package.json and the workflow files to .prettierignore because they currently use tab-width: 2 instead of 4 like the prettier config says.

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (aadfce0) to head (cdad948).

Additional details and impacted files
@@             Coverage Diff              @@
##           development     #223   +/-   ##
============================================
  Coverage        82.85%   82.85%           
============================================
  Files               46       46           
  Lines             4189     4189           
  Branches          1043     1043           
============================================
  Hits              3471     3471           
  Misses             689      689           
  Partials            29       29           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@m00sey m00sey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this lgtm, but I am not digesting it daily.

@lenkan lenkan merged commit e2b2f6e into WebOfTrust:development Mar 1, 2024
8 checks passed
@lenkan lenkan deleted the simplify-prettier-setup branch March 1, 2024 15:36
daviddm pushed a commit to daviddm/signify-ts that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants