Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: method waiting for long running operation #236

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

lenkan
Copy link
Collaborator

@lenkan lenkan commented Mar 23, 2024

Added a method to wait for longrunning operation in the Operations class. Rewrote the tests to the pattern used in aiding.test.ts. Also using this new method in the integration test.

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.91%. Comparing base (39580ef) to head (2f21f4b).

❗ Current head 2f21f4b differs from pull request most recent head 1c1b2e3. Consider uploading reports for the commit 1c1b2e3 to get more accurate results

Files Patch % Lines
src/keri/app/coring.ts 94.73% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           development     #236      +/-   ##
===============================================
+ Coverage        82.75%   82.91%   +0.15%     
===============================================
  Files               46       47       +1     
  Lines             4234     4220      -14     
  Branches          1053     1055       +2     
===============================================
- Hits              3504     3499       -5     
+ Misses             725      692      -33     
- Partials             5       29      +24     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lenkan lenkan force-pushed the feat-wait-operation branch from 2f21f4b to 1c1b2e3 Compare April 11, 2024 18:36
@lenkan lenkan merged commit 4c0072f into WebOfTrust:development Apr 12, 2024
8 checks passed
@lenkan lenkan deleted the feat-wait-operation branch April 12, 2024 07:47
daviddm pushed a commit to daviddm/signify-ts that referenced this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants