URL enconding of AID alias name in rest calls

[rodolfomiranda]

This PR fix issue #204 Handling of special characters and white spaces in alias names by adding a missing url encoding and the correct content-length calculation.

Without changes in KERIA it will fix the spaces and some special characters such as @ and $, but not other special character such as the ö letter used in Swedish.
In KERIA, it seems that Falcon modifies the req.path when passing it to the middleware that check signatures. Need further investigation.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.85%. Comparing base (e2b2f6e) to head (5636686).
Report is 1 commits behind head on development.

Additional details and impacted files

@@               Coverage Diff               @@
##           development     #233      +/-   ##
===============================================
- Coverage        82.86%   82.85%   -0.01%     
===============================================
  Files               46       47       +1     
  Lines             4190     4200      +10     
  Branches          1044     1046       +2     
===============================================
+ Hits              3472     3480       +8     
- Misses             689      691       +2     
  Partials            29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[lenkan]

Nice! It would be nice with a unit test for the path encoding. Should be fairly straightforward in aiding.test.ts

[rodolfomiranda]

Nice! It would be nice with a unit test for the path encoding. Should be fairly straightforward in aiding.test.ts

added

[lenkan]

Nice! It would be nice with a unit test for the path encoding. Should be fairly straightforward in aiding.test.ts

added

I believe the added test does not invoke the get method? Only the create, which does not do any encodeURIComponent.

Should be something like this

  await client.identifiers().get("a name with ñ!")
  const lastCall = client.getLastMockRequest();
  assert.equal(lastCall.path, '/identifiers/a%20name%20with%20%C3%B1!');

[rodolfomiranda]

You are right. I updated the code.

[lenkan]

LGTM

[lenkan]

@rodolfomiranda Should we merge this?

[rodolfomiranda]

@rodolfomiranda Should we merge this?

Yes!