-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix credentialing field ordering and related singlesig-vlei-issuance test #254
Conversation
2byrds
commented
Apr 29, 2024
•
edited
Loading
edited
- Fixes ordering of u field.
- Modifies signed fetch to give the caller control over Request related args.
- Improves reliability of singlesig-vlei-issuer test
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
…ta. This is a breaking change Signed-off-by: 2byrds <[email protected]>
… out Signed-off-by: 2byrds <[email protected]>
… out Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
+ Coverage 82.76% 82.82% +0.06%
==========================================
Files 46 46
Lines 4218 4210 -8
Branches 1029 1049 +20
==========================================
- Hits 3491 3487 -4
+ Misses 722 694 -28
- Partials 5 29 +24 ☔ View full report in Codecov by Sentry. |
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! Much easier to review now. I don't understand the changes with the retries? Does the retry
function not do this for you?
Also, if not too much effort, can the changes to signedFetch be separated to it's own PR to make it easier to review the history? I feel these are two unrelated changes.
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
Signed-off-by: 2byrds <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM