-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize code; use custom iterator #303
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work, Jenny - I like this update. Also great to hear that performance is better as well.
I was on the fence if we should extend the dailyiterator or have a separate virtual/abstract class that the daily/weekly/monthly iterators extend. But, I think this works. Well done!
@AndersonTarren - thanks, I was on the fence as well. We can iterate down the road too if we decide it makes more sense. Thanks for the review! |
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Asteroids DoD document to see any additional details for the items below
**Lurch:attach W-000000
or**Lurch:add