Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize code; use custom iterator #303

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

jjbennett
Copy link
Contributor

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Asteroids DoD document to see any additional details for the items below

  • Place holder data is incorporated (Refer to Case Management Sample Data document)
  • Base axe-core JEST test included for any new LWC (No critical violations)
  • CRUD/FLS is enforced in Apex
  • Update & Test permission sets to account for new features and CRUD/FLS
  • All modified classes are unit tested (Apex) at 100% coverage
  • UX approval or UX not necessary
  • PR contains draft release notes
  • Attach work item to the pull request with Lurch **Lurch:attach W-000000 or **Lurch:add
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
    • QA
  • QE story level testing completed

@AndersonTarren AndersonTarren added the in dev review Review is in progress label Sep 29, 2020
Copy link
Contributor

@AndersonTarren AndersonTarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, Jenny - I like this update. Also great to hear that performance is better as well.

I was on the fence if we should extend the dailyiterator or have a separate virtual/abstract class that the daily/weekly/monthly iterators extend. But, I think this works. Well done!

@jjbennett
Copy link
Contributor Author

@AndersonTarren - thanks, I was on the fence as well. We can iterate down the road too if we decide it makes more sense. Thanks for the review!

@AndersonTarren AndersonTarren added ready to merge and removed in dev review Review is in progress labels Sep 29, 2020
@AndersonTarren AndersonTarren merged commit 6002a59 into feature/Winter-21 Sep 30, 2020
@AndersonTarren AndersonTarren deleted the feature/Winter21__iterate branch September 30, 2020 15:43
@AndersonTarren AndersonTarren mentioned this pull request Dec 15, 2020
12 tasks
@davidmreed davidmreed mentioned this pull request Dec 17, 2020
12 tasks
@jjbennett jjbennett mentioned this pull request Dec 17, 2020
6 tasks
@jjbennett jjbennett mentioned this pull request Dec 24, 2020
12 tasks
@AndersonTarren AndersonTarren mentioned this pull request Jan 5, 2021
12 tasks
@bethbrains bethbrains mentioned this pull request Jan 20, 2021
12 tasks
@AndersonTarren AndersonTarren mentioned this pull request Nov 4, 2022
12 tasks
@AndersonTarren AndersonTarren mentioned this pull request Nov 14, 2022
12 tasks
@dmkud dmkud mentioned this pull request Nov 29, 2022
12 tasks
This was referenced Jan 12, 2023
This was referenced Mar 13, 2023
@jjbennett jjbennett mentioned this pull request Aug 14, 2023
12 tasks
@AndersonTarren AndersonTarren mentioned this pull request Sep 21, 2023
12 tasks
@AndersonTarren AndersonTarren mentioned this pull request Nov 7, 2023
12 tasks
@jjbennett jjbennett mentioned this pull request Jan 19, 2024
12 tasks
This was referenced Jul 26, 2024
@jjbennett jjbennett mentioned this pull request Sep 17, 2024
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants