Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cause to error message; easily create Rosa user #385

Merged
merged 3 commits into from
Dec 22, 2020
Merged

Add cause to error message; easily create Rosa user #385

merged 3 commits into from
Dec 22, 2020

Conversation

jjbennett
Copy link
Contributor

@jjbennett jjbennett commented Dec 22, 2020 •
edited by kselvocki
Loading

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Asteroids DoD document to see any additional details for the items below
Any net new LWC work has Sa11y tests & 50% or above lines JEST test coverage
CRUD/FLS is enforced in Apex
Permission sets are updated to account for CRUD|FLS|Tab|Classes
Field sets are updated to account for new fields

  • UX approval or UX not necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name (Reorganize code; use custom iterator #303)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
    • QA
      PR contains draft release notes
  • QE story level testing completed

@jjbennett jjbennett requested a review from a team as a code owner December 22, 2020 15:01
@jjbennett
Copy link
Contributor Author

W-8603748

davidmreed
davidmreed approved these changes Dec 22, 2020
View reviewed changes
cumulusci.yml
- PMDM_Deliver
- PMDM_Manage
user_alias: rosa
ignore_failure: True
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but n.b. this task will not fail if re-run. It only assigns those Permission Sets not already assigned.

bmuniswamy
bmuniswamy approved these changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@bmuniswamy bmuniswamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Thanks for building this flow out. It makes it so much easier for us.

@kselvocki kselvocki added in QE review in QE review and removed ready for review labels Dec 22, 2020
@kselvocki kselvocki merged commit a247ada into master Dec 22, 2020
@kselvocki kselvocki deleted the feature/rosa branch December 22, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmuniswamy bmuniswamy bmuniswamy approved these changes

@davidmreed davidmreed davidmreed approved these changes

Assignees
No one assigned
Labels
in QE review in QE review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jjbennett @davidmreed @bmuniswamy @kselvocki