Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Service Schedule Modal Error #674

Merged
merged 1 commit into from
Nov 8, 2023
Merged

Service Schedule Modal Error #674

merged 1 commit into from
Nov 8, 2023

Conversation

AndersonTarren
Copy link
Contributor

Critical Changes

Changes

Addresses a modal error by limiting the times that we call the close event.

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Asteroids DoD document to see any additional details for the items below

  • Any net new LWC work has Sa11y tests & 50% or above lines JEST test coverage
  • CRUD/FLS is enforced in Apex
  • Permission sets are updated to account for CRUD|FLS|Tab|Classes
  • Field sets are updated to account for new fields
  • UX approval or UX not necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name (Reorganize code; use custom iterator #303)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
    • QA
  • PR contains draft release notes
  • QE story level testing completed

@AndersonTarren
Copy link
Contributor Author

W-14270030

jjbennett
jjbennett approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@jjbennett jjbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and makes sense!

@jjbennett jjbennett merged commit 9f5888a into feature/248 Nov 8, 2023
12 of 14 checks passed
@jjbennett jjbennett deleted the feature/248__sched-wizard-error branch November 8, 2023 21:10
@salesforce-org-metaci salesforce-org-metaci bot mentioned this pull request Nov 8, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbennett jjbennett jjbennett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndersonTarren @jjbennett