Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sort order for BSDT Comboboxes #664

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Sort order for BSDT Comboboxes #664

merged 2 commits into from
Jan 17, 2023

Conversation

AndersonTarren
Copy link
Contributor

@AndersonTarren AndersonTarren commented Jan 12, 2023 •
edited by voduyemi
Loading

Critical Changes

Changes

Adds ORDER BY clauses for apex methods returning records for BSDT comboboxes.

  • Cohorts
  • Program Engagements
  • Services

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Asteroids DoD document to see any additional details for the items below

  • Any net new LWC work has Sa11y tests & 50% or above lines JEST test coverage
  • CRUD/FLS is enforced in Apex
  • Permission sets are updated to account for CRUD|FLS|Tab|Classes
  • Field sets are updated to account for new fields
  • UX approval or UX not necessary
  • Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name (Reorganize code; use custom iterator #303)
  • All acceptance criteria have been met
    • Developer
    • Code Reviewer
    • QA
  • PR contains draft release notes
  • QE story level testing completed

@AndersonTarren AndersonTarren changed the base branch from main to feature/244 January 12, 2023 21:48
@AndersonTarren
Copy link
Contributor Author

AndersonTarren commented Jan 12, 2023 •
edited
Loading

W-12236667
W-12236669
W-12236671

@AndersonTarren AndersonTarren marked this pull request as ready for review January 12, 2023 22:48
@voduyemi voduyemi self-requested a review January 13, 2023 17:42
voduyemi
voduyemi approved these changes Jan 17, 2023
View reviewed changes
Copy link
Contributor

@voduyemi voduyemi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks @AndersonTarren

@voduyemi voduyemi merged commit 3fa4673 into feature/244 Jan 17, 2023
@voduyemi voduyemi deleted the feature/244_bsdt-pick-alpha branch January 17, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voduyemi voduyemi voduyemi approved these changes

@jjbennett jjbennett Awaiting requested review from jjbennett

Assignees
No one assigned
Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndersonTarren @voduyemi