Add list view filter to recent sessions home page component. #376

jjbennett · 2020-12-11T14:42:17Z

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Refer to Asteroids DoD document to see any additional details for the items below

Any net new LWC work has Sa11y tests & 50% or above lines JEST test coverage
~~CRUD/FLS is enforced in Apex~~
~~Permission sets are updated to account for CRUD|FLS|Tab|Classes~~
~~Field sets are updated to account for new fields~~
UX approval or UX not necessary
Link the pull request and work item by PR comment and Chatter post respectively, e.g. GUS: W-0000000: Work Name (Reorganize code; use custom iterator #303)
All acceptance criteria have been met
- Developer
- Code Reviewer
- QA
  ~~PR contains draft release notes~~
QE story level testing completed

jjbennett · 2020-12-11T14:45:01Z

force-app/main/default/labels/CustomLabels.labels-meta.xml

+        <language>en_US</language>
+        <protected>true</protected>
+        <shortDescription>Warning when list view limit is reached.</shortDescription>
+        <value>The selected list view has 2000+ records, all matching records may not be displayed.</value>


@lbeller - good morning, we have a warning message that will be displayed if the list view selected to filter the recent sessions component contains 2000+ records. Screen shot attached still pending UX approval. Thanks!

@jjbennett , thanks! Here's suggested wording: There are over 2,000 records. Some records may not be shown.

…sic jest test

jjbennett · 2020-12-11T21:58:00Z

W-8530184

lbeller · 2020-12-11T18:35:11Z

force-app/main/default/labels/CustomLabels.labels-meta.xml

+        <language>en_US</language>
+        <protected>true</protected>
+        <shortDescription>Warning when list view limit is reached.</shortDescription>
+        <value>The selected list view has 2000+ records, all matching records may not be displayed.</value>


@jjbennett , thanks! Here's suggested wording: There are over 2,000 records. Some records may not be shown.

bethbrains · 2020-12-14T23:53:56Z

force-app/main/default/lwc/listViewSelector/listViewSelector.js

+        this.pageToken = this.previousPageToken;
+    }
+
+    set options(data) {


we haven't used non-@api setters like this much...if at all. neato!

bethbrains

A few questions!

bethbrains · 2020-12-14T23:57:14Z

force-app/main/default/lwc/recentSessions/recentSessions.html

+                        <label class="slds-form-element__label slds-m-bottom_none">
+                            {labels.listView}
+                        </label>
+                        <div class="slds-form-element__control">
+                            <c-list-view-selector
+                                object-api-name={objectApiName}
+                                onselect={handleListViewSelected}
+                            ></c-list-view-selector>
+                        </div>


need to semantically link the label to the element with a for= and an id=

bethbrains · 2020-12-14T23:57:42Z

force-app/main/default/lwc/recentSessions/recentSessions.html

+                </lightning-layout-item>
+                <lightning-layout-item>
+                    <div class="slds-form-element slds-var-p-left_small">
+                        <label class="slds-form-element__label slds-m-bottom_none">


same. link the label to the element.

bethbrains · 2020-12-14T23:58:02Z

force-app/main/default/lwc/recentSessions/recentSessions.html

+                </lightning-layout-item>
+            </lightning-layout>
+        </div>
+        <div class="slds-var-p-around_small" style="background-color:#f3f2f2">


style in markup? is a there a reason it's not in the css file?

Laziness lol, no other explanation I can find :)

bethbrains · 2020-12-14T23:58:35Z

force-app/main/default/lwc/listViewSelector/listViewSelector.js

+
+import userId from "@salesforce/user/Id";
+import pmmFolder from "@salesforce/resourceUrl/pmm";
+import LIST_VIEW_LABEL from "@salesforce/label/c.List_Views";


Can you make this const plural LIST_VIEWS_LABEL for consistency?

bethbrains · 2020-12-15T00:03:56Z

force-app/main/default/lwc/scopedNotification/scopedNotification.js

+        if (this.rounded) {
+            slds += " slds-box";
+        }
+


is this part of the scoped notif spec?

I don't think so, UX wanted rounded corners.

bethbrains · 2020-12-15T00:04:26Z

force-app/main/default/staticresources/pmm/listViewSelectorOverrides.css

@@ -0,0 +1,10 @@
+.listViewSelector button,


curious, why a separate file?

Doesn't appear to be necessary, moving it. Thanks for the catch!

Actually since they are overriding lwc base components it does need to be an override.

but you pulled them out of the other static resource file? can't we keep them all in one file?

future-proofing. got it.

bmuniswamy

Just one comment. I was joking on the other one.

bmuniswamy · 2020-12-15T15:53:09Z

force-app/main/default/lwc/listViewSelector/listViewSelector.js

+        pageToken: "$pageToken",
+    })
+    listView({ error, data }) {
+        if (data && data.records) {


@jjbennett , No early return here.. Just j/k

bmuniswamy · 2020-12-15T16:47:12Z

force-app/main/default/lwc/listViewSelector/listViewSelector.html

+        <lightning-layout-item padding="horizontal-small">
+            <lightning-button-icon-stateful
+                icon-name="utility:pin"
+                alternative-text={labels.pinListView}


@jjbennett , Can we add a hover text too so the users can see it just like the standard list view.

Done, thanks for the suggestion!

bethbrains

good work! off to QE.

bethbrains · 2020-12-15T18:19:03Z

force-app/main/default/staticresources/pmm/listViewSelectorOverrides.css

@@ -0,0 +1,10 @@
+.listViewSelector button,


but you pulled them out of the other static resource file? can't we keep them all in one file?

bethbrains · 2020-12-15T18:24:05Z

force-app/main/default/staticresources/pmm/listViewSelectorOverrides.css

@@ -0,0 +1,10 @@
+.listViewSelector button,


future-proofing. got it.

jjbennett added 4 commits December 10, 2020 08:30

Add list view selector component

470fa65

wip: get records in JS

2fb0907

Use wire and pin list view

2cc5317

Add pinned item and list view records limit warning

911bc9e

jjbennett requested review from AndersonTarren, lbeller and smarovich as code owners December 11, 2020 14:42

jjbennett added the wip Work in progress label Dec 11, 2020

jjbennett changed the base branch from master to feature/attendance December 11, 2020 14:43

jjbennett commented Dec 11, 2020

View reviewed changes

jjbennett added 2 commits December 11, 2020 14:47

Extract out list view selector overrides; remove side effects; add ba…

e964eb2

…sic jest test

UX design tweaks

3013890

jjbennett changed the title ~~wip: Add list view filter to recent sessions home page component.~~ Add list view filter to recent sessions home page component. Dec 11, 2020

jjbennett added ready for review and removed wip Work in progress labels Dec 11, 2020

jjbennett added 2 commits December 11, 2020 17:34

UX tweak padding and margins.

53610ec

UX tweaks final padding adjustments and fix gray background

d6fe9c0

lbeller approved these changes Dec 14, 2020

View reviewed changes

Update from string review

a377f9b

bethbrains reviewed Dec 14, 2020

View reviewed changes

bethbrains suggested changes Dec 15, 2020

View reviewed changes

bmuniswamy reviewed Dec 15, 2020

View reviewed changes

Changes based on PR review feedback

d0f33ea

bethbrains approved these changes Dec 15, 2020

View reviewed changes

bethbrains added ready for QE and removed ready for review labels Dec 15, 2020

lbeller approved these changes Dec 15, 2020

View reviewed changes

Merge a52be9e into feature/attendance__listview-filter

eb60297

Merge 6415d1e into feature/attendance__listview-filter

40630b0

rmonica08 added in QE review in QE review and removed ready for QE labels Dec 16, 2020

jjbennett added 2 commits December 16, 2020 11:32

Api name is not namespaced; return no records when no records in list

e8c4b9a

Fix jest test to check label vs value

23b82d7

rmonica08 merged commit 05da799 into feature/attendance Dec 16, 2020

rmonica08 deleted the feature/attendance__listview-filter branch December 16, 2020 18:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add list view filter to recent sessions home page component. #376

Add list view filter to recent sessions home page component. #376

jjbennett commented Dec 11, 2020 •

edited

Loading

jjbennett Dec 11, 2020

lbeller Dec 11, 2020

jjbennett commented Dec 11, 2020 •

edited

Loading

lbeller Dec 11, 2020

bethbrains Dec 14, 2020

bethbrains left a comment

bethbrains Dec 14, 2020

bethbrains Dec 14, 2020

bethbrains Dec 14, 2020

jjbennett Dec 15, 2020

bethbrains Dec 14, 2020

bethbrains Dec 15, 2020

jjbennett Dec 15, 2020

bethbrains Dec 15, 2020

jjbennett Dec 15, 2020

jjbennett Dec 15, 2020

bethbrains Dec 15, 2020

bethbrains Dec 15, 2020

bmuniswamy left a comment

bmuniswamy Dec 15, 2020

bmuniswamy Dec 15, 2020

jjbennett Dec 15, 2020

bethbrains left a comment

bethbrains Dec 15, 2020

bethbrains Dec 15, 2020

Add list view filter to recent sessions home page component. #376

Add list view filter to recent sessions home page component. #376

Conversation

jjbennett commented Dec 11, 2020 • edited Loading

Critical Changes

Changes

Issues Closed

New Metadata

Deleted Metadata

Definition of Done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjbennett commented Dec 11, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bethbrains left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bmuniswamy left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bethbrains left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jjbennett commented Dec 11, 2020 •

edited

Loading

jjbennett commented Dec 11, 2020 •

edited

Loading