Tweaks from Sprint Review #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbennett
requested review from
AndersonTarren,
lbeller and
smarovich
as code owners
bethbrains
reviewed
Dec 17, 2020
| @@ -680,7 +680,7 @@ | |||
| <language>en_US</language> | |||
| <protected>true</protected> | |||
| <shortDescription>Warning when list view limit is reached.</shortDescription> | |||
| <value>There are over 2,000 records. Some records may not be shown.</value> | |||
| <value>This List View has over 2,000 records. Some records may not be shown.</value> | |||
There was a problem hiding this comment.
@lbeller - list view or List View?
bethbrains
approved these changes
Dec 17, 2020
There was a problem hiding this comment.
One quick Q for @lbeller but otherwise looks great. You are so thorough, @jjbennett !!
lbeller
requested changes
Dec 17, 2020
| @@ -680,7 +680,7 @@ | |||
| <language>en_US</language> | |||
| <protected>true</protected> | |||
| <shortDescription>Warning when list view limit is reached.</shortDescription> | |||
| <value>There are over 2,000 records. Some records may not be shown.</value> | |||
| <value>This List View has over 2,000 records. Some records may not be shown.</value> | |||
|
Thanks for catching that @bethbrains and for the quick feedback @lbeller - the capitalization has been fixed. |
lbeller
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Critical Changes
Changes
Issues Closed
New Metadata
Deleted Metadata
Definition of Done
Refer to Asteroids DoD document to see any additional details for the items below
Any net new LWC work has Sa11y tests & 50% or above lines JEST test coverageCRUD/FLS is enforced in ApexPermission sets are updated to account for CRUD|FLS|Tab|ClassesField sets are updated to account for new fieldsUX approval or UX not necessaryPR contains draft release notes