Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: update v0.17 branch with latest code for release #2528

Merged
merged 10 commits into from
Aug 9, 2023
Merged

*: update v0.17 branch with latest code for release #2528

merged 10 commits into from
Aug 9, 2023

Commits on Aug 9, 2023

  1. dkg: increase bcast receive timeout (#2490) 

    Makes DKG P2P receive timeout configurable and increases it from the default 5s to 1min allowing peers to broadcast messages much earlier and having them wait longer for the receiver to handle to properly.

This was encountered in large DKG where some peers are much slower than others, still doing key generation even though others are already sharing node sigs and erroring after 5s since the slow peer doensn't have a lock hash yet to verify the received node sigs.

category: refactor
ticket: none
    @corverroos @gsora
    corverroos authored and gsora committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    279223a View commit details
    Browse the repository at this point in the history

  2. p2p: set default send timeout (#2494) 

    We didn't actually set timeouts when sending libp2p messages, only when receiving message. Not setting timeouts is bad practice. See more info on this [here](https://dev.to/bearer/the-importance-of-request-timeouts-l3n) and [here](https://medium.com/booking-com-development/io-socket-timeout-socket-timeout-made-easy-4dfd43e777f7).

This sets the send timeout equivalent to the read timeout, allowing up to 1s latency between nodes, so read timeout+2s.

category: misc
ticket: none
    @corverroos @gsora
    corverroos authored and gsora committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    db87f30 View commit details
    Browse the repository at this point in the history

  3. dkg: exchange sigTypes concurrently (#2496) 

    Before this commit, calling `exchange()` would listen for new incoming messages and discard everything that didn't carry the expected `sigType`.

In a DKG one node might fall behind the others (for example, while DKG'ing 3000 validator keys) and send `sigTypes` that the other peers have already received threshold for.

This PR makes sure a given instance of `exchanger` will hold onto all messages whose `sigTypes` are specified during its initialization phase.

Calling `exchange()` will return as soon as there are enough messages for the specified `sigType`, but different `sigType`s messages will still be stored and will be returned when requested by means of another `exchange()` call, with a different `sigType` argument.

category: bug
ticket: #2491

Closes #2491.
    @gsora
    gsora committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    4c32aa8 View commit details
    Browse the repository at this point in the history

  4. dkg/sync: introduce explicit sync steps (#2509) 

    Introduces explicit sync steps in DKG, allowing all peers to wait for other to complete each step before continuing to next step. This prevents fast peers timing out sending stuff to slow peers. It also mitigates against shutdown races.

category: bug
ticket: #887
    @corverroos @gsora
    corverroos authored and gsora committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    694dda5 View commit details
    Browse the repository at this point in the history

  5. dkg: wait for all validator key sigs (#2510) 

    Wait until all peer's validator signatures over exchanger-handled data.

This should fix nightly test.

category: bug
ticket: none
    @gsora
    gsora committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    6c30a76 View commit details
    Browse the repository at this point in the history

  6. testutil/compose: integrate p2p fuzz to compose (#2504) 

    Integrates p2p fuzz to compose.

category: test
ticket: #2375
    @dB2510 @gsora
    dB2510 authored and gsora committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2a9e2a6 View commit details
    Browse the repository at this point in the history

  7. *: bump go version to 1.20.7 (#2511) 

    Also fixes latest `govulncheck` issues.


category: misc
ticket: none
    @gsora
    gsora committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    45783e4 View commit details
    Browse the repository at this point in the history

  8. dkg: lockstep success message (#2514) 

    Make every peer participating in the DKG wait for the "slow" one, and synchronize the `Successfully completed DKG ceremony 🎉` message output.


category: misc
ticket: none
    @gsora
    gsora committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    2998ce3 View commit details
    Browse the repository at this point in the history

  9. core/validatorapi: close proxy requests on shutdown (#2516) 

    Fixes soft shutdown by cancelling long running proxied requests.

This is because long lived connections are not interrupted by `http.Server.Shutdown`:
```
// Shutdown gracefully shuts down the server without interrupting any
// active connections. Shutdown works by first closing all open
// listeners, then closing all idle connections, and then waiting
// indefinitely for connections to return to idle and then shut down...
```

category: bug
ticket: #2435
    @corverroos @gsora
    corverroos authored and gsora committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    805e0aa View commit details
    Browse the repository at this point in the history

  10. app/obolapi: create cluster launchpad URL (#2518) 

    Add the `LaunchpadURLForLock` method, which generates a Launchpad cluster dashboard URL for a given cluster lock.

Reference this method in `dkg` and `create cluster` commands so that at the end of those processes, if the user has specified `--publish`, the Launchpad dashboard URL will be printed on the console.

category: feature
ticket: #2423 

Closes #2423.
    @gsora
    gsora committed Aug 9, 2023
    Configuration menu
    Copy the full SHA
    7352fde View commit details
    Browse the repository at this point in the history