*: update v0.17 branch with latest code for release #2528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes DKG P2P receive timeout configurable and increases it from the default 5s to 1min allowing peers to broadcast messages much earlier and having them wait longer for the receiver to handle to properly. This was encountered in large DKG where some peers are much slower than others, still doing key generation even though others are already sharing node sigs and erroring after 5s since the slow peer doensn't have a lock hash yet to verify the received node sigs. category: refactor ticket: none
We didn't actually set timeouts when sending libp2p messages, only when receiving message. Not setting timeouts is bad practice. See more info on this [here](https://dev.to/bearer/the-importance-of-request-timeouts-l3n) and [here](https://medium.com/booking-com-development/io-socket-timeout-socket-timeout-made-easy-4dfd43e777f7). This sets the send timeout equivalent to the read timeout, allowing up to 1s latency between nodes, so read timeout+2s. category: misc ticket: none
Before this commit, calling `exchange()` would listen for new incoming messages and discard everything that didn't carry the expected `sigType`. In a DKG one node might fall behind the others (for example, while DKG'ing 3000 validator keys) and send `sigTypes` that the other peers have already received threshold for. This PR makes sure a given instance of `exchanger` will hold onto all messages whose `sigTypes` are specified during its initialization phase. Calling `exchange()` will return as soon as there are enough messages for the specified `sigType`, but different `sigType`s messages will still be stored and will be returned when requested by means of another `exchange()` call, with a different `sigType` argument. category: bug ticket: #2491 Closes #2491.
Introduces explicit sync steps in DKG, allowing all peers to wait for other to complete each step before continuing to next step. This prevents fast peers timing out sending stuff to slow peers. It also mitigates against shutdown races. category: bug ticket: #887
Wait until all peer's validator signatures over exchanger-handled data. This should fix nightly test. category: bug ticket: none
Integrates p2p fuzz to compose. category: test ticket: #2375
Make every peer participating in the DKG wait for the "slow" one, and synchronize the `Successfully completed DKG ceremony 🎉` message output. category: misc ticket: none
Fixes soft shutdown by cancelling long running proxied requests. This is because long lived connections are not interrupted by `http.Server.Shutdown`: ``` // Shutdown gracefully shuts down the server without interrupting any // active connections. Shutdown works by first closing all open // listeners, then closing all idle connections, and then waiting // indefinitely for connections to return to idle and then shut down... ``` category: bug ticket: #2435
Add the `LaunchpadURLForLock` method, which generates a Launchpad cluster dashboard URL for a given cluster lock. Reference this method in `dkg` and `create cluster` commands so that at the end of those processes, if the user has specified `--publish`, the Launchpad dashboard URL will be printed on the console. category: feature ticket: #2423 Closes #2423.
github-actions
bot
added
the
branch-release
corverroos
approved these changes
Aug 9, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main-v0.17 #2528 +/- ##
==============================================
+ Coverage 53.54% 53.72% +0.17%
==============================================
Files 198 198
Lines 26756 26931 +175
==============================================
+ Hits 14326 14468 +142
- Misses 10645 10662 +17
- Partials 1785 1801 +16
☔ View full report in Codecov by Sentry. |
gsora
added
the
merge when ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PRs have been cherry-picked:
1.20.7#2511category: misc
ticket: none