app/obolapi: create cluster launchpad URL

[gsora]

Add the LaunchpadURLForLock method, which generates a Launchpad cluster dashboard URL for a given cluster lock.

Reference this method in dkg and create cluster commands so that at the end of those processes, if the user has specified --publish, the Launchpad dashboard URL will be printed on the console.

category: feature
ticket: #2423

Closes #2423.

[gsora]

Solving merge conflicts rn.

[gsora]

Done, ready for review.

Needs input from @f1lander / @HananINouman / @OisinKyne for URL format (see Slack) and general UX.

[codecov]

Codecov Report

Patch coverage: 71.69% and project coverage change: +0.03% 🎉

Comparison is base (d35f366) 53.70% compared to head (6347970) 53.74%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2518      +/-   ##
==========================================
+ Coverage   53.70%   53.74%   +0.03%     
==========================================
  Files         199      199              
  Lines       26908    26938      +30     
==========================================
+ Hits        14451    14477      +26     
- Misses      10659    10661       +2     
- Partials     1798     1800       +2     

Files Changed	Coverage Δ
cmd/createcluster.go	59.82% <52.94%> (-0.24%)	⬇️
dkg/dkg.go	57.12% <61.53%> (+<0.01%)	⬆️
app/obolapi/api.go	65.51% <91.30%> (+17.69%)	⬆️

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[gsora]

For reference, this is how it appears to users when a DKG with --publish completes.

/cc @Battenfield

[corverroos]

I would keep baseURL a string since this pointer trick is easy to miss when adding more functions which can result in bugs.

[gsora]

What do you think about this? Validate url in New(), and provide a url() method that returns it as *url.URL, panic-ing if parsing fails: since validation happens in New(), if it fails later it's a very weird situation:

// New returns a new Client.
func New(urlStr string) (Client, error) {
	_, err := url.ParseRequestURI(urlStr) // check that urlStr is valid
	if err != nil {
		return Client{}, errors.Wrap(err, "could not parse Obol API URL")
	}

	return Client{
		baseURL: urlStr,
	}, nil
}

// Client is the REST client for obol-api requests.
type Client struct {
	baseURL string // Base obol-api URL
}

func (c Client) url() *url.URL {
	baseURL, err := url.ParseRequestURI(c.baseURL)
	if err != nil {
		panic(errors.Wrap(err, "could not parse Obol API URL, this should never happen"))
	}

	return baseURL
}

[corverroos]

sure, could also just return the error from url(), don't think the effort to omit errors is super valuable.