dkg: wait for all validator key sigs #2510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wait until all peer's validator signatures over exchanger-handled data. This should fix nightly test.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2510 +/- ##
==========================================
- Coverage 53.65% 53.62% -0.03%
==========================================
Files 199 199
Lines 26813 26821 +8
==========================================
- Hits 14387 14384 -3
- Misses 10643 10651 +8
- Partials 1783 1786 +3
☔ View full report in Codecov by Sentry. |
corverroos
approved these changes
Aug 4, 2023
Test that we received all signatures for all public keys, and that we received all sigTypes data from everybody
corverroos
approved these changes
Aug 4, 2023
gsora
added
the
merge when ready
gsora
added a commit
that referenced
this pull request
Aug 9, 2023
Wait until all peer's validator signatures over exchanger-handled data. This should fix nightly test. category: bug ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until all peer's validator signatures over exchanger-handled data.
This should fix nightly test.
category: bug
ticket: none