Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the processing of incomplete data packets during DKG #2513

Closed
boulder225 opened this issue Aug 4, 2023 · 1 comment
Closed

Prevent the processing of incomplete data packets during DKG #2513

boulder225 opened this issue Aug 4, 2023 · 1 comment
Assignees
Labels
protocol Protocol Team tickets

Comments

@boulder225
Copy link

🎯 Problem to be solved

During the Exchanger refactor, an oversight occurred where a check was omitted. This omission allows incomplete data packets during DKG (Distributed Key Generation) to be processed. This could lead to potential errors or vulnerabilities within the system, impacting the integrity of the key generation process.

🛠️ Proposed solution

We need to reintroduce the omitted check into the Exchanger code to resolve this issue. The proposed steps include:

  1. Identify the Check: Review the previous versions of the Exchanger code to identify the omitted check that prevented the processing of incomplete data packets.

  2. Implement the Check: Re-implement the identified check in the current version of the Exchanger, ensuring that handles incomplete data packets during DKG.

  3. Testing: test the updated code with different scenarios, including cases with incomplete data packets, to ensure that the reintroduced check works as expected.

  4. Monitoring and Follow-up: Monitor the system after deployment to detect any unexpected behavior or issues and make necessary adjustments.

By implementing and testing the reintroduction of this check, we can ensure that the Exchanger component prevents the processing of incomplete data packets during DKG, maintaining the overall security and integrity of the system.

@github-actions github-actions bot added the protocol Protocol Team tickets label Aug 4, 2023
@gsora
Copy link
Collaborator

gsora commented Aug 7, 2023

Fixed by #2510

@gsora gsora closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol Protocol Team tickets
Projects
None yet
Development

No branches or pull requests

2 participants