testutil/compose: integrate p2p fuzz to compose #2504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2504 +/- ##
==========================================
- Coverage 53.65% 53.65% -0.01%
==========================================
Files 199 199
Lines 26813 26818 +5
==========================================
+ Hits 14387 14389 +2
- Misses 10643 10647 +4
+ Partials 1783 1782 -1
☔ View full report in Codecov by Sentry. |
corverroos
reviewed
Aug 2, 2023
dB2510
commented
Aug 2, 2023
Comment on lines
+44
to
+48
| charonCmd := cmdRun | ||
| if conf.P2PFuzz { | ||
| nodes[0].EnvVars = append(nodes[0].EnvVars, kv{"p2p-fuzz", fmt.Sprintf(`"%v"`, conf.P2PFuzz)}) | ||
| charonCmd = cmdUnsafeRun | ||
| } |
There was a problem hiding this comment.
@corverroos only node0 has p2p-fuzz enabled.
corverroos
approved these changes
Aug 2, 2023
corverroos
approved these changes
Aug 3, 2023
dB2510
force-pushed
the
dhruv/composep2pfuzz
branch
from
e61547f
to
e0ba231
Compare
dB2510
added
the
merge when ready
gsora
pushed a commit
that referenced
this pull request
Aug 9, 2023
Integrates p2p fuzz to compose. category: test ticket: #2375
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates p2p fuzz to compose.
category: test
ticket: #2375