dkg: increase bcast receive timeout #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2490 +/- ##
==========================================
+ Coverage 53.52% 53.59% +0.07%
==========================================
Files 198 198
Lines 26757 26760 +3
==========================================
+ Hits 14321 14343 +22
+ Misses 10648 10632 -16
+ Partials 1788 1785 -3
☔ View full report in Codecov by Sentry. |
dB2510
approved these changes
Aug 1, 2023
corverroos
added
the
merge when ready
gsora
pushed a commit
that referenced
this pull request
Aug 9, 2023
Makes DKG P2P receive timeout configurable and increases it from the default 5s to 1min allowing peers to broadcast messages much earlier and having them wait longer for the receiver to handle to properly. This was encountered in large DKG where some peers are much slower than others, still doing key generation even though others are already sharing node sigs and erroring after 5s since the slow peer doensn't have a lock hash yet to verify the received node sigs. category: refactor ticket: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes DKG P2P receive timeout configurable and increases it from the default 5s to 1min allowing peers to broadcast messages much earlier and having them wait longer for the receiver to handle to properly.
This was encountered in large DKG where some peers are much slower than others, still doing key generation even though others are already sharing node sigs and erroring after 5s since the slow peer doensn't have a lock hash yet to verify the received node sigs.
category: refactor
ticket: none