This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Merge NuGet.Services.Metadata into NuGet.Jobs #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Initial implementation. Added command line arguments to catalog2lucene to find flat container. Added code that generates proper icon url. Added tests. * test fix * Spelling, minor refactoring.
Merge branch 'dev' into master Progress on NuGet/NuGetGallery#7293
Also see: [NuGetDeployment#974](https://nuget.visualstudio.com/NuGetMicrosoft/_git/NuGetDeployment/pullrequest/974?_a=files) This work is part of: NuGet/NuGetGallery#7296
[ReleasePrep][2019.06.26]FI of master into dev
[ReleasePrep][2019.06.26]RI of dev into master
Fix bug when UTC timestamp becomes local time Progress on NuGet/NuGetGallery#7226
Merge branch 'dev' into master
AuxiliaryFileClient is currently only used by search service. Now it will be used by Auxiliary2AzureSearch as well. Progress on NuGet/NuGetGallery#6447
This document will be used by Auxiliary2AzureSearh to update just the download count fields in the search index. Progress on NuGet/NuGetGallery#6447
…uilder (#585) This logic is already implemented for Owners2AzureSearch: get a package ID version list, find all of the applicable search filters, create a small document per search filter, yield the index actions. Any job that is just updated the search index can use this logic. Progress on NuGet/NuGetGallery#6447
This adds functional tests for the new custom analyzer for packages' tags.
A 412 can happen if the downloads.v1.json gets written while the blob is being read Also retry on an timeout from reading an HTTP-based cursor Address NuGet/NuGetGallery#8076
* Add sort by downloads WIP * Add sort by download in response builder Use the auxiliary file to sort by downloads before returning a response * Add Asc and Desc sorting for downloads * Add functional tests for AdvancedSearch sorting * Add unit tests for AdvancedSearch sorting * Fix sorting variable in AdvancedSearch * Add filtering parameter to AdvancedSearch * Update comment on SearchReponseBuilder * Add thenBy newest * Fix tests for sorting order * Simplified test cases for SearchResponseBuilder * Fix tests * Not using Random anymore for tests * reverting packageType change * Fix test styling * Remove unused import * Add packagetype parameter to V2 endpoint * Add exceptions if invalid advanced search on Hijack index * Add SearchController tests for packageType filter * Add SearchParametersBuilder tests for packageType filter * Add IndexOperationBuilder tests for packageType filter * Add functional tests for package type filter * V2 search now throws error 400 when using A-S on Hijack * Update test case to catch the correct exception type
[ReleasePrep][2020.06.29]RI of dev into master
Add vulnerability info to db2catalog
[Search] Merge the A/B test for exactly matching on tags
[Advanced Search] Add sorting & filtering to the search service (#794)
[ReleasePrep][2020.07.08]RI of dev into master
[ReleasePrep][2020.07.14]FI master into dev
* Update SearchService README * Update src/NuGet.Services.SearchService/README.md Co-authored-by: Loïc Sharma <[email protected]> * Update src/NuGet.Services.SearchService/README.md Co-authored-by: Loïc Sharma <[email protected]> Co-authored-by: Loïc Sharma <[email protected]>
# Conflicts: # .gitignore # .nuget/packages.config # LICENSE.txt # README.md # build.ps1 # buildandtest.ps1 # sign.thirdparty.props # test.ps1
loic-sharma
approved these changes
Aug 1, 2020
|
It looks like we also need the following follow-up tasks:
Do you think it'd be worthwhile to deploy one job/service from each release build we migrate? |
joelverhagen
force-pushed
the
jver-merge
branch
from
f30c3e4 to
bc5138b
Compare
joelverhagen
changed the title
zhhyu
approved these changes
Aug 10, 2020
ryuyu
approved these changes
Aug 10, 2020
Align ServerCommon versions
joelverhagen
force-pushed
the
jver-merge
branch
from
bc5138b to
fb2bbbc
Compare
joelverhagen
added a commit
that referenced
this pull request
Oct 26, 2020
NuGet.Services.Metadata history is left intact and merged into the NuGet.Jobs history. Address NuGet/Engineering#2669
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address https://github.com/NuGet/Engineering/issues/2669.
The approach taken was to add NuGet.Services.Metadata as a remote on my local NuGet.Jobs clone, then merge NuGet.Services.Metadata's
devbranch into NuGet.Jobsdevbranch, allowing unrelated histories.The merge conflicts were essentially places where both repositories had files with the same name. I logically merged the files that have the same name and merged the NuGet.Services.Metadata projects into NuGet.Jobs.sln.
All commits before merge commit 2fe83de are the originals from NuGet.Services.Metadata. Everything afterwards is reviewable on a commit-to-commit basis.
I plan on NOT squashing so we can retain history on a per-file basis.
Follow-up tasks: