This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 21
[Search] Generate secondary region's auxiliary data #555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
requested review from
joelverhagen,
agr,
xavierdecoster,
shishirx34,
ryuyu,
dtivel,
chenriksson,
cristinamanum,
skofman1,
scottbommarito and
zhhyu
September 19, 2018 22:13
ryuyu
approved these changes
Sep 19, 2018
@@ -0,0 +1,22 @@ | |||
{ | |||
"Initialization": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we call this file southeastasia
instead of seasia
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
@@ -0,0 +1,22 @@ | |||
{ | |||
"Initialization": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same. southeastasia
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed
joelverhagen
approved these changes
Sep 19, 2018
joelverhagen
pushed a commit
that referenced
this pull request
Sep 27, 2019
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Tweaks the `Search.GenerateAuxiliaryData` job to generate auxiliary data for each region, including secondary regions (like US South Central and South East Asia).
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tweaks the
Search.GenerateAuxiliaryData
job to generate auxiliary data for each region, including secondary regions (like US South Central and South East Asia).