This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Add more telemetry for monitoring. #575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinamanum
requested review from
shishirx34,
scottbommarito,
chenriksson,
loic-sharma,
zhhyu,
agr,
ryuyu and
joelverhagen
shishirx34
approved these changes
Oct 8, 2018
| return ValidationResult.FailedWithIssues(ValidationIssue.SymbolErrorCode_ChecksumDoesNotMatch); | ||
| } | ||
| } | ||
| } | ||
| _telemetryService.TrackSymbolsValidationResultEvent(packageId, packageNormalizedVersion, ValidationStatus.Failed, "SymbolErrorCode_MatchingPortablePDBNotFound"); |
There was a problem hiding this comment.
make the issue as the constant field or a new class with const string if you are incorporating multiple issues.
There was a problem hiding this comment.
Not multiple issues currently.
scottbommarito
approved these changes
Oct 8, 2018
| @@ -76,6 +76,7 @@ public async Task<IValidationResult> ValidateSymbolsAsync(string packageId, stri | |||
| { | |||
| if (!SymbolsHaveMatchingPEFiles(pdbs, pes)) | |||
| { | |||
| _telemetryService.TrackSymbolsValidationResultEvent(packageId, packageNormalizedVersion, ValidationStatus.Failed, "SymbolErrorCode_MatchingPortablePDBNotFound"); | |||
There was a problem hiding this comment.
It may be better if you added a layer above this that tracked the telemetry rather than having to put a telemetry service call at every return.
You may have to add a reason string to the IValidationResult but I think the code would be much cleaner.
E.g.
public async Task<IValidationResult> ValidateSymbolsAsync(...)
{
var result = await ValidateSymbolsInternal(...);
_telemetryService.TrackSymbolsValidationResultEvent(result);
}
public Task<IValidationResult> ValidateSymbolsInternal(...) { ... }
There was a problem hiding this comment.
I see your point. I prefer to not refactor too much for this change, If more data will be added will consider more refactoring at that point.
joelverhagen
pushed a commit
that referenced
this pull request
Sep 27, 2019
[ReleasePrep][2019.06.26]FI of master into dev
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Add more telemetry for monitoring.
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
[ReleasePrep][2019.06.26]FI of master into dev
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add few more data points to be exported in Geneva.