This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Add email service support for the symbols. #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristinamanum
commented
Sep 25, 2018
| private string GalleryPackageUrl(Package package) => string.Format(_emailConfiguration.PackageUrlTemplate, package.PackageRegistration.Id, package.NormalizedVersion); | ||
| private string PackageSupportUrl(Package package) => string.Format(_emailConfiguration.PackageSupportTemplate, package.PackageRegistration.Id, package.NormalizedVersion); | ||
| } | ||
| } |
There was a problem hiding this comment.
This file is renamed to PackageMessageService and moved under MessageService/PackageMessageService.cs
cristinamanum
commented
Sep 25, 2018
| await _coreMessageService.SendValidationTakingTooLongNoticeAsync(package, GalleryPackageUrl(package.PackageRegistration.Id, package.NormalizedVersion)); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
This is not new code but the file was renamed and changed its location.
cristinamanum
commented
Sep 25, 2018
| @@ -112,7 +112,7 @@ | |||
| <Version>2.28.0</Version> | |||
| </PackageReference> | |||
| <PackageReference Include="NuGetGallery.Core"> | |||
| <Version>4.4.5-master-37818</Version> | |||
| <Version>4.4.4-dev-40792</Version> | |||
There was a problem hiding this comment.
This will need to be changed to a master version before submit.
cristinamanum
commented
Sep 25, 2018
| @@ -23,7 +23,7 @@ | |||
| <dependency id="NuGet.Services.Storage" version="2.28.0" /> | |||
| <dependency id="NuGet.Services.Validation" version="2.28.0" /> | |||
| <dependency id="NuGet.Services.Validation.Issues" version="2.28.0" /> | |||
| <dependency id="NuGetGallery.Core" version="4.4.5-master-37818" /> | |||
| <dependency id="NuGetGallery.Core" version="4.4.4-dev-40792" /> | |||
There was a problem hiding this comment.
This will be changed to a master version before submit.
cristinamanum
requested review from
scottbommarito,
loic-sharma,
chenriksson,
shishirx34,
zhhyu,
skofman1,
ryuyu,
agr and
joelverhagen
chenriksson
approved these changes
Sep 25, 2018
|
|
||
| namespace NuGet.Services.Validation.Orchestrator | ||
| { | ||
| //ToDo: https://github.com/NuGet/NuGetGallery/issues/6255 |
| } | ||
|
|
||
| public string GalleryPackageUrl(string packageId, string packageNormalizedVersion) => string.Format(EmailConfiguration.PackageUrlTemplate, packageId, packageNormalizedVersion); | ||
| public string PackageSupportUrl(string packageId, string packageNormalizedVersion) => string.Format(EmailConfiguration.PackageSupportTemplate, packageId, packageNormalizedVersion); |
There was a problem hiding this comment.
For PackageMessageService, this is included in the service class. Can we be consistent w/ which pattern we use?
There was a problem hiding this comment.
It was removed from there. They are both(PackageMessageService and SymbolsPackageMessageService) follow the same pattern.
| <Compile Include="Symbols\SymbolScanOnlyConfiguration.cs" /> | ||
| <Compile Include="Symbols\SymbolCriteriaEvaluator.cs" /> | ||
| <Compile Include="Symbols\SymbolScanValidator.cs" /> | ||
| <Compile Include="PackageSigning\Scan\ScanValidator.cs" /> | ||
| <Compile Include="Services\IEntityService.cs" /> | ||
| <Compile Include="IMessageService.cs" /> | ||
| <Compile Include="MessageService\IMessageService.cs" /> |
There was a problem hiding this comment.
Why not put these under "Orchestrator/Services"? More consistent w/ what we do in Gallery.
| @@ -93,7 +93,7 @@ private void ConfigureDatabaseServices(IServiceCollection services) | |||
| services.AddScoped<IEntitiesContext>(p => | |||
| { | |||
| var connectionFactory = p.GetRequiredService<ISqlConnectionFactory<GalleryDbConfiguration>>(); | |||
| var connection = connectionFactory.CreateAsync().GetAwaiter().GetResult(); | |||
| System.Data.Common.DbConnection connection = connectionFactory.CreateAsync().GetAwaiter().GetResult(); | |||
| @@ -45,6 +45,7 @@ | |||
| <Compile Include="Configuration\ConfigurationValidatorFacts.cs" /> | |||
| <Compile Include="Configuration\CoreMessageServiceConfigurationFacts.cs" /> | |||
| <Compile Include="Configuration\TopologicalSortFacts.cs" /> | |||
| <Compile Include="SymbolsMessageServiceFacts.cs" /> | |||
| <Compile Include="MessageServiceFacts.cs" /> | |||
There was a problem hiding this comment.
Can we put these in the same directories as the runtime source? i.e., "Orchestrator.Tests/MessageService" (or "Orchestrator.Tests/Services" if you change it...)
shishirx34
approved these changes
Sep 28, 2018
joelverhagen
pushed a commit
that referenced
this pull request
Sep 27, 2019
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
* Add message support for symbols.
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add email service support for the symbols.