Skip to content
This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
/ NuGet.Jobs Public archive

Status - unit tests #580

Merged
merged 5 commits into from
Oct 12, 2018
Merged

Status - unit tests #580

merged 5 commits into from
Oct 12, 2018

Conversation

scottbommarito
Copy link

This PR consists of a TON of unit tests and a small amount of style/bug fixes.

joelverhagen
joelverhagen approved these changes Oct 11, 2018
View reviewed changes
Copy link
Member

@joelverhagen joelverhagen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just curious, what does a test coverage report bring up?

@scottbommarito
Copy link
Author

@joelverhagen - statusaggregator.exe is at 56.95% coverage, but this is mostly because

  1. I didn't test the constructors because they're all very simple and DI will throw anyway if services are missing.
  2. I didn't write tests for the DI and some DI helper classes. It didn't seem very worthwhile because the process will throw at runtime if things are misconfigured anyway.
  3. I forgot to write tests for StatusAggregator.Parse. I will work on them with the rest of the day.

agr
agr approved these changes Oct 11, 2018
View reviewed changes
Copy link
Contributor

@agr agr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@scottbommarito
Copy link
Author

Adding StatusAggregator.Parse tests. Coverage is now 67.45%.

@scottbommarito scottbommarito merged commit c3aeb02 into sb-groupfactory Oct 12, 2018
@scottbommarito scottbommarito deleted the sb-grouptests branch October 12, 2018 00:37
joelverhagen added a commit that referenced this pull request Sep 27, 2019
@joelverhagen
Add the initial Auxiliary2AzureSearch job (#580)
8910efe 
Progress on NuGet/NuGetGallery#6447
joelverhagen added a commit that referenced this pull request Oct 26, 2020
@joelverhagen
Add the initial Auxiliary2AzureSearch job (#580)
8aced95 
Progress on NuGet/NuGetGallery#6447
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@agr agr agr approved these changes

@joelverhagen joelverhagen joelverhagen approved these changes

@loic-sharma loic-sharma Awaiting requested review from loic-sharma

@xavierdecoster xavierdecoster Awaiting requested review from xavierdecoster

@shishirx34 shishirx34 Awaiting requested review from shishirx34

@nugetlurker nugetlurker Awaiting requested review from nugetlurker

@zivkan zivkan Awaiting requested review from zivkan

@ryuyu ryuyu Awaiting requested review from ryuyu

@chenriksson chenriksson Awaiting requested review from chenriksson

@cristinamanum cristinamanum Awaiting requested review from cristinamanum

@skofman1 skofman1 Awaiting requested review from skofman1

@zhhyu zhhyu Awaiting requested review from zhhyu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scottbommarito @joelverhagen @agr