This repository has been archived by the owner on Jul 30, 2024. It is now read-only.
Status - add export logic for two-layer aggregation #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
zivkan,
ryuyu,
chenriksson,
cristinamanum,
skofman1 and
zhhyu
added 4 commits
October 5, 2018 13:22
…into sb-groupexport
…into sb-groupexport
…into sb-groupexport
Can we remove this? Seems like the specific JSON serialization is an implementation detail so simpler is better. Refers to: src/StatusAggregator/Export/StatusContractResolver.cs:15 in e7c586e. [](commit_id = e7c586e, deletion_comment = False) |
joelverhagen
reviewed
Oct 5, 2018
|
|
||
| if (currentComponent == null) | ||
| { | ||
| _logger.LogWarning("Couldn't find component corresponding to active entities."); |
There was a problem hiding this comment.
LogWarning [](start = 36, length = 10)
Why isn't this an exception?
added 5 commits
October 5, 2018 15:17
…into sb-groupexport
…into sb-groupexport
…into sb-groupexport
joelverhagen
pushed a commit
that referenced
this pull request
Oct 26, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the export logic (that generates the
status.jsonfile) that was broken by #563.Previously, only
EventEntitys were exported--now we need to exportIncidentGroupEntitys as well.I would suggest starting at
StatusExporter.