Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync main feature branch 6.0.0 - 8/8 #11400

Conversation

c2thorn
Copy link
Member

@c2thorn c2thorn commented Aug 8, 2024

Release Note Template for Downstream PRs (will be copied)


haiyanmeng and others added 30 commits August 1, 2024 13:08
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
zli82016 and others added 6 commits August 7, 2024 14:27
…n-FEATURE-BRANCH-6.0.0

# Conflicts:
#	mmv1/third_party/terraform/services/cloudrunv2/resource_cloud_run_v2_job_test.go.erb
#	mmv1/third_party/terraform/services/sql/resource_sql_database_instance.go.erb
#	mmv1/third_party/terraform/services/sql/resource_sql_database_instance_test.go
#	mmv1/third_party/terraform/website/docs/guides/version_6_upgrade.html.markdown
@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@modular-magician

This comment was marked as outdated.

@c2thorn c2thorn force-pushed the sync-main-FEATURE-BRANCH-6.0.0 branch from a654426 to 3c34235 Compare August 9, 2024 11:50
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 133 files changed, 8956 insertions(+), 1763 deletions(-))
google-beta provider: Diff ( 135 files changed, 8865 insertions(+), 1805 deletions(-))
terraform-google-conversion: Diff ( 11 files changed, 667 insertions(+), 5 deletions(-))
Open in Cloud Shell: Diff ( 7 files changed, 29 insertions(+), 13 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_access_context_manager_service_perimeter_dry_run_egress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_egress_policy" "primary" {
  egress_from {
    identities         = # value needed
    identity_type      = # value needed
    source_restriction = # value needed
    sources {
      access_level = # value needed
    }
  }
  egress_to {
    external_resources = # value needed
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_access_context_manager_service_perimeter_dry_run_ingress_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_access_context_manager_service_perimeter_dry_run_ingress_policy" "primary" {
  ingress_from {
    identities    = # value needed
    identity_type = # value needed
    sources {
      access_level = # value needed
      resource     = # value needed
    }
  }
  ingress_to {
    operations {
      method_selectors {
        method     = # value needed
        permission = # value needed
      }
      service_name = # value needed
    }
    resources = # value needed
  }
  perimeter = # value needed
}

Resource: google_compute_instance (292 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance" "primary" {
  confidential_instance_config {
    confidential_instance_type = # value needed
  }
}

Resource: google_compute_instance_from_machine_image (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_machine_image" "primary" {
  confidential_instance_config {
    confidential_instance_type = # value needed
  }
}

Resource: google_compute_instance_from_template (13 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_from_template" "primary" {
  confidential_instance_config {
    confidential_instance_type = # value needed
  }
}

Resource: google_compute_instance_template (206 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_instance_template" "primary" {
  confidential_instance_config {
    confidential_instance_type = # value needed
  }
}

Resource: google_compute_region_instance_template (54 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_compute_region_instance_template" "primary" {
  confidential_instance_config {
    confidential_instance_type = # value needed
  }
}

Resource: google_project (876 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  skip_delete = # value needed
}

Resource: google_scc_v2_organization_source_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_source_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_scc_v2_organization_source_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_source_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_sql_database_instance (125 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_sql_database_instance" "primary" {
  settings {
    ip_configuration {
      enable_private_path_for_google_cloud_services = # value needed
      require_ssl                                   = # value needed
      server_ca_mode                                = # value needed
    }
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3893
Passed tests: 3508
Skipped tests: 383
Affected tests: 2

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestCheckForCommonAliasIp

Tests were added that are GA-only additions and require manual runs:

  • TestAccComputeHealthCheck_srcRegions_update
  • TestAccLoggingLogViewIamBindingGenerated
  • TestAccLoggingLogViewIamBindingGenerated_withAndWithoutCondition
  • TestAccLoggingLogViewIamBindingGenerated_withCondition
  • TestAccLoggingLogViewIamMemberGenerated
  • TestAccLoggingLogViewIamMemberGenerated_withAndWithoutCondition
  • TestAccLoggingLogViewIamMemberGenerated_withCondition
  • TestAccLoggingLogViewIamPolicyGenerated
  • TestAccLoggingLogViewIamPolicyGenerated_withCondition

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataSourceArtifactRegistryDockerImage
  • TestAccNetworkServicesLbRouteExtension_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccDataSourceArtifactRegistryDockerImage[Error message] [Debug log]
TestAccNetworkServicesLbRouteExtension_update[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@c2thorn c2thorn requested a review from shuyama1 August 9, 2024 15:42
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Don't forget to commit merge:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.