-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a flag to use patch when creating a service networking connection fails #11364
Add a flag to use patch when creating a service networking connection fails #11364
Conversation
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
|
Tests analyticsTotal tests: 8 Click here to see the affected service packages
Action takenFound 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for creating a separate PR for this
fixes hashicorp/terraform-provider-google#16697
In provider 4.x, resource
google_service_networking_connection
is soft deleted withremovePeering
method.After upgrading to 5.x, creating the resource
google_service_networking_connection
in the same network and different peering ranges fails. When the fieldupdate_on_creation_fail
is set to true, the creation will succeed by calling PATCH method after creation fails.one pager doc is here
Release Note Template for Downstream PRs (will be copied)