Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to use patch when creating a service networking connection fails #11364

Conversation

zli82016
Copy link
Member

@zli82016 zli82016 commented Aug 5, 2024

fixes hashicorp/terraform-provider-google#16697

In provider 4.x, resource google_service_networking_connection is soft deleted with removePeering method.
After upgrading to 5.x, creating the resource google_service_networking_connection in the same network and different peering ranges fails. When the field update_on_creation_fail is set to true, the creation will succeed by calling PATCH method after creation fails.

one pager doc is here

Release Note Template for Downstream PRs (will be copied)

servicenetworking: added `update_on_creation_fail` field to `google_service_networking_connection` resource. When it is set to true, enforce an update of the reserved peering ranges on the existing service networking connection in case of a new connection creation failure.

@zli82016 zli82016 changed the title Add a flag to use patch when creating a service networking connection… Add a flag to use patch when creating a service networking connection fails Aug 5, 2024
@zli82016 zli82016 requested a review from c2thorn August 5, 2024 21:25
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 110 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 110 insertions(+), 1 deletion(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 8
Passed tests: 7
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • servicenetworking

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccServiceNetworkingConnection_updateOnCreationFail

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccServiceNetworkingConnection_updateOnCreationFail[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for creating a separate PR for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating a service networking connection resource, check if Create or Update is needed
3 participants