Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a flag to use patch when creating a service networking connection fails #7915

Conversation

modular-magician
Copy link
Collaborator

fixes hashicorp/terraform-provider-google#16697

In provider 4.x, resource google_service_networking_connection is soft deleted with removePeering method.
After upgrading to 5.x, creating the resource google_service_networking_connection in the same network and different peering ranges fails. When the field update_on_creation_fail is set to true, the creation will succeed by calling PATCH method after creation fails.

one pager doc is here

Release Note Template for Downstream PRs (will be copied)

servicenetworking: added `update_on_creation_fail` field to `google_service_networking_connection` resource. When it is set to true, enforce an update of the reserved peering ranges on the existing service networking connection in case of a new connection creation failure.

Derived from GoogleCloudPlatform/magic-modules#11364

… fails (#11364)

[upstream:6af157ec0f4671062b20902414b20d30b0390f63]

Signed-off-by: Modular Magician <[email protected]>
@modular-magician modular-magician merged commit e9d01d6 into hashicorp:main Aug 7, 2024
4 checks passed
@modular-magician modular-magician deleted the downstream-pr-6af157ec0f4671062b20902414b20d30b0390f63 branch November 16, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When creating a service networking connection resource, check if Create or Update is needed
1 participant