Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization Source iam #10881

Merged
merged 41 commits into from
Aug 6, 2024
Merged

Conversation

thokalavinod
Copy link
Contributor

Related to http://b/330538229.
Issue No: https://b.corp.google.com/issues/339718614
Issue No: https://b.corp.google.com/issues/339718347
Issue No: https://b.corp.google.com/issues/339718346

Adding new template to move from SCC API v1 → SCC Management API for post-V2-GA release customers and to support
https://cloud.google.com/security-command-center/docs/reference/rest/v2/organizations.sources

@github-actions github-actions bot requested a review from c2thorn June 5, 2024 00:21
Copy link

github-actions bot commented Jun 5, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 5, 2024
@github-actions github-actions bot requested a review from c2thorn June 5, 2024 17:36
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 5, 2024
@github-actions github-actions bot requested a review from c2thorn June 5, 2024 18:53
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 5, 2024
@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jun 6, 2024
Copy link

github-actions bot commented Jun 7, 2024

This PR has been waiting for review for 2 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

Copy link

@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@modular-magician modular-magician added service/securitycenter and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 10, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 13 files changed, 992 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 13 files changed, 992 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 421 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_organization_source (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_source" "primary" {
  canonical_name = # value needed
  description    = # value needed
  display_name   = # value needed
  organization   = # value needed
}

Resource: google_scc_v2_organization_source_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_source_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
  members      = # value needed
  organization = # value needed
  role         = # value needed
  source       = # value needed
}

Resource: google_scc_v2_organization_source_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_source_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
  member       = # value needed
  organization = # value needed
  role         = # value needed
  source       = # value needed
}

Resource: google_scc_v2_organization_source_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_source_iam_policy" "primary" {
  organization = # value needed
  policy_data  = # value needed
  source       = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 3767
Passed tests: 3384
Skipped tests: 379
Affected tests: 4

Click here to see the affected service packages
all service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccLoggingBucketConfigOrganization_basic|TestAccSCCOrganizationSource_complete|TestAccTpuV2Vm_tpuV2VmFullExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccLoggingBucketConfigOrganization_basic[Error message] [Debug log]
TestAccSCCOrganizationSource_complete[Error message] [Debug log]
TestAccTpuV2Vm_tpuV2VmFullExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Please fix these to complete your PR.}}$
View the build log or the debug log for each test

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jun 11, 2024
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterV2OrganizationSourceIamBinding
  • TestAccSecurityCenterV2OrganizationSourceIamMember
  • TestAccSecurityCenterV2OrganizationSourceIamPolicy
  • TestAccSecurityCenterV2OrganizationSource_basic
    $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 5, 2024
Copy link
Member

@c2thorn c2thorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rerunning build

@modular-magician modular-magician removed the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Aug 5, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1129 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 1119 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 411 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_source (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_source" "primary" {
  description  = # value needed
  display_name = # value needed
  organization = # value needed
}

Resource: google_scc_v2_source_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_source_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
  members      = # value needed
  organization = # value needed
  role         = # value needed
  source       = # value needed
}

Resource: google_scc_v2_source_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_source_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
  member       = # value needed
  organization = # value needed
  role         = # value needed
  source       = # value needed
}

Resource: google_scc_v2_source_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_source_iam_policy" "primary" {
  organization = # value needed
  policy_data  = # value needed
  source       = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 0
Passed tests: 0
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages
  • securitycenterv2
#### Non-exercised tests

Tests were added that are skipped in VCR:

  • TestAccSecurityCenterV2OrganizationSourceIamBinding
  • TestAccSecurityCenterV2OrganizationSourceIamMember
  • TestAccSecurityCenterV2OrganizationSourceIamPolicy
  • TestAccSecurityCenterV2OrganizationSource_basic
    $\textcolor{red}{\textsf{Errors occurred during REPLAYING mode. Please fix them to complete your PR.}}$

View the build log

@github-actions github-actions bot requested a review from c2thorn August 5, 2024 21:22
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 5, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1130 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 1120 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 411 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_source (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_source" "primary" {
  description  = # value needed
  display_name = # value needed
  organization = # value needed
}

Resource: google_scc_v2_source_iam_binding (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_source_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
  members      = # value needed
  organization = # value needed
  role         = # value needed
  source       = # value needed
}

Resource: google_scc_v2_source_iam_member (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_source_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
  member       = # value needed
  organization = # value needed
  role         = # value needed
  source       = # value needed
}

Resource: google_scc_v2_source_iam_policy (0 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_source_iam_policy" "primary" {
  organization = # value needed
  policy_data  = # value needed
  source       = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 9
Passed tests: 5
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • securitycenterv2

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterV2OrganizationSourceIamBinding
  • TestAccSecurityCenterV2OrganizationSourceIamMember
  • TestAccSecurityCenterV2OrganizationSourceIamPolicy
  • TestAccSecurityCenterV2OrganizationSource_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterV2OrganizationSourceIamBinding[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationSourceIamMember[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationSourceIamPolicy[Error message] [Debug log]
TestAccSecurityCenterV2OrganizationSource_basic[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

@github-actions github-actions bot requested a review from c2thorn August 5, 2024 21:59
@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Aug 5, 2024
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 10 files changed, 1130 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 8 files changed, 1120 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 4 files changed, 411 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_organization_source_iam_binding (2 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_source_iam_binding" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

Resource: google_scc_v2_organization_source_iam_member (1 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_organization_source_iam_member" "primary" {
  condition {
    description = # value needed
    expression  = # value needed
    title       = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 10
Passed tests: 6
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • securitycenterv2

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccSecurityCenterV2OrganizationSourceIamBinding
  • TestAccSecurityCenterV2OrganizationSourceIamMember
  • TestAccSecurityCenterV2OrganizationSourceIamPolicy
  • TestAccSecurityCenterV2OrganizationSource_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterV2OrganizationSourceIamBinding[Debug log]
TestAccSecurityCenterV2OrganizationSourceIamMember[Debug log]
TestAccSecurityCenterV2OrganizationSourceIamPolicy[Debug log]
TestAccSecurityCenterV2OrganizationSource_basic[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$


$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

@c2thorn c2thorn merged commit 8299248 into GoogleCloudPlatform:main Aug 6, 2024
15 checks passed
rainshen49 pushed a commit to rainshen49/magic-modules that referenced this pull request Aug 12, 2024
BBBmau pushed a commit to bschaatsbergen/magic-modules that referenced this pull request Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants