-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organization Source iam #10881
Organization Source iam #10881
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
This PR has been waiting for review for 2 weekdays. Please take a look! Use the label |
@c2thorn This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_scc_v2_organization_source" "primary" {
canonical_name = # value needed
description = # value needed
display_name = # value needed
organization = # value needed
}
Resource: resource "google_scc_v2_organization_source_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
members = # value needed
organization = # value needed
role = # value needed
source = # value needed
}
Resource: resource "google_scc_v2_organization_source_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
member = # value needed
organization = # value needed
role = # value needed
source = # value needed
}
Resource: resource "google_scc_v2_organization_source_iam_policy" "primary" {
organization = # value needed
policy_data = # value needed
source = # value needed
}
|
Tests analyticsTotal tests: Click here to see the affected service packagesall service packages are affected Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected testsTestAccComputeInstanceNetworkIntefaceWithSecurityPolicy|TestAccLoggingBucketConfigOrganization_basic|TestAccSCCOrganizationSource_complete|TestAccTpuV2Vm_tpuV2VmFullExample |
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rerunning build
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_scc_v2_source" "primary" {
description = # value needed
display_name = # value needed
organization = # value needed
}
Resource: resource "google_scc_v2_source_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
members = # value needed
organization = # value needed
role = # value needed
source = # value needed
}
Resource: resource "google_scc_v2_source_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
member = # value needed
organization = # value needed
role = # value needed
source = # value needed
}
Resource: resource "google_scc_v2_source_iam_policy" "primary" {
organization = # value needed
policy_data = # value needed
source = # value needed
}
|
Tests analyticsTotal tests: 0 Click here to see the affected service packages
Tests were added that are skipped in VCR:
View the build log |
mmv1/third_party/terraform/services/securitycenterv2/iam_scc_v2_organization_source_test.go
Show resolved
Hide resolved
mmv1/third_party/terraform/services/securitycenterv2/iam_scc_v2_organization_source_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/securitycenterv2/iam_scc_v2_organization_source_test.go
Outdated
Show resolved
Hide resolved
mmv1/third_party/terraform/services/securitycenterv2/iam_scc_v2_organization_source_test.go
Outdated
Show resolved
Hide resolved
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_scc_v2_source" "primary" {
description = # value needed
display_name = # value needed
organization = # value needed
}
Resource: resource "google_scc_v2_source_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
members = # value needed
organization = # value needed
role = # value needed
source = # value needed
}
Resource: resource "google_scc_v2_source_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
member = # value needed
organization = # value needed
role = # value needed
source = # value needed
}
Resource: resource "google_scc_v2_source_iam_policy" "primary" {
organization = # value needed
policy_data = # value needed
source = # value needed
}
|
Tests analyticsTotal tests: 9 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_scc_v2_organization_source_iam_binding" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
Resource: resource "google_scc_v2_organization_source_iam_member" "primary" {
condition {
description = # value needed
expression = # value needed
title = # value needed
}
}
|
Tests analyticsTotal tests: 10 Click here to see the affected service packages
Action takenFound 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
|
|
Related to http://b/330538229.
Issue No: https://b.corp.google.com/issues/339718614
Issue No: https://b.corp.google.com/issues/339718347
Issue No: https://b.corp.google.com/issues/339718346
Adding new template to move from SCC API v1 → SCC Management API for post-V2-GA release customers and to support
https://cloud.google.com/security-command-center/docs/reference/rest/v2/organizations.sources