Add force_destroy field to google_storage_managed_folder

[juliocc]

This PR introduces a force_destroy field for google_storage_managed_folder resources.

Fixes hashicorp/terraform-provider-google#18553 which was left as a pending action from #10786 (comment)

storage: added `force_destroy` field to `google_storage_managed_folder` resource

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@SarahFrench, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 101 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 101 insertions(+), 1 deletion(-))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 101 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 101 insertions(+), 1 deletion(-))

[modular-magician]

Tests analytics

Total tests: 106
Passed tests: 89
Skipped tests: 9
Affected tests: 8

Click here to see the affected service packages

• storage

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageManagedFolderIamBindingGenerated
• TestAccStorageManagedFolderIamBindingGenerated_withCondition
• TestAccStorageManagedFolderIamMemberGenerated
• TestAccStorageManagedFolderIamMemberGenerated_withCondition
• TestAccStorageManagedFolderIamPolicyGenerated
• TestAccStorageManagedFolderIamPolicyGenerated_withCondition
• TestAccStorageManagedFolder_storageManagedFolderBasicExample
• TestAccStorageManagedFolder_storageManagedFolderUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccStorageManagedFolderIamBindingGenerated[Debug log]
TestAccStorageManagedFolderIamBindingGenerated_withCondition[Debug log]
TestAccStorageManagedFolderIamMemberGenerated[Debug log]
TestAccStorageManagedFolderIamMemberGenerated_withCondition[Debug log]
TestAccStorageManagedFolderIamPolicyGenerated[Debug log]
TestAccStorageManagedFolderIamPolicyGenerated_withCondition[Debug log]
TestAccStorageManagedFolder_storageManagedFolderBasicExample[Debug log]
TestAccStorageManagedFolder_storageManagedFolderUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Tests analytics

Total tests: 106
Passed tests: 89
Skipped tests: 9
Affected tests: 8

Click here to see the affected service packages

• storage

Action taken

Found 8 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageManagedFolderIamBindingGenerated
• TestAccStorageManagedFolderIamBindingGenerated_withCondition
• TestAccStorageManagedFolderIamMemberGenerated
• TestAccStorageManagedFolderIamMemberGenerated_withCondition
• TestAccStorageManagedFolderIamPolicyGenerated
• TestAccStorageManagedFolderIamPolicyGenerated_withCondition
• TestAccStorageManagedFolder_storageManagedFolderBasicExample
• TestAccStorageManagedFolder_storageManagedFolderUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccStorageManagedFolderIamBindingGenerated[Debug log]
TestAccStorageManagedFolderIamBindingGenerated_withCondition[Debug log]
TestAccStorageManagedFolderIamMemberGenerated[Debug log]
TestAccStorageManagedFolderIamMemberGenerated_withCondition[Debug log]
TestAccStorageManagedFolderIamPolicyGenerated[Debug log]
TestAccStorageManagedFolderIamPolicyGenerated_withCondition[Debug log]
TestAccStorageManagedFolder_storageManagedFolderBasicExample[Debug log]
TestAccStorageManagedFolder_storageManagedFolderUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 138 insertions(+), 1 deletion(-))
google-beta provider: Diff ( 3 files changed, 138 insertions(+), 1 deletion(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_storage_managed_folder (11 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_storage_managed_folder" "primary" {
  force_destroy = # value needed
}

[modular-magician]

Tests analytics

Total tests: 106
Passed tests: 96
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages

• storage

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageManagedFolder_storageManagedFolderUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccStorageManagedFolder_storageManagedFolderUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 144 insertions(+), 5 deletions(-))
google-beta provider: Diff ( 4 files changed, 144 insertions(+), 5 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 106
Passed tests: 96
Skipped tests: 9
Affected tests: 1

Click here to see the affected service packages

• storage

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageManagedFolder_storageManagedFolderBasicExample

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccStorageManagedFolder_storageManagedFolderBasicExample[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[juliocc]

Tests failed during RECORDING mode: TestAccStorageManagedFolder_storageManagedFolderBasicExample[Error message] [Debug log]

Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Should I do something about this error? Not sure why it fails now.

[SarahFrench]

Thanks for updating the acceptance test! I've left some guidance about addressing the test failure and after that's solved I'm happy to merge

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 127 insertions(+), 6 deletions(-))
google-beta provider: Diff ( 4 files changed, 127 insertions(+), 6 deletions(-))
Open in Cloud Shell: Diff ( 1 file changed, 3 insertions(+), 2 deletions(-))

[modular-magician]

Tests analytics

Total tests: 106
Passed tests: 95
Skipped tests: 9
Affected tests: 2

Click here to see the affected service packages

• storage

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccStorageManagedFolder_storageManagedFolderBasicExample
• TestAccStorageManagedFolder_storageManagedFolderUpdate

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccStorageManagedFolder_storageManagedFolderBasicExample[Debug log]
TestAccStorageManagedFolder_storageManagedFolderUpdate[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log or the debug log for each test

[SarahFrench]

Thanks for iterating on the tests with me, this looks good to merge now