Add Resource SCC V2 Project Nofitification Config

[vijaykanthm]

Related to http://b/309603080.

Bug Description: hashicorp/terraform-provider-google#16427

Adding new template for SCC API V2 Project Notification Config
https://cloud.google.com/security-command-center/docs/reference/rest/v2/projects.locations.notificationConfigs

Release Note Template for Downstream PRs (will be copied)

`google_scc_v2_project_notification_config`

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@BBBmau, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[vijaykanthm]

Hi @BBBmau, can you please approve the trigger so that CI will continue the next steps. Thanks.

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[roaks3]

Heads up that #10817 is extremely related. I would ask that you please make every attempt to test this implementation locally, as I'm asking the other contributor to do, to avoid a high volume of requests to trigger CI runs.

[github-actions]

@GoogleCloudPlatform/terraform-team @BBBmau This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

[roaks3]

@BBBmau Just to follow up on the above, I was able to follow up with this contributor over chat, and they were able to get their local setup working up to the point where the pubsub_topic needs to be created. Their test environment prevents topic creation for the moment, so they can't fully run these tests locally, and the manager of their environment is OOO for 2+ weeks.

That is to say, we will need to rely on CI runs (and manual approvals) for testing this PR.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1028 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1018 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

[modular-magician]

Tests analytics

Total tests: 6859
Passed tests: 3425
Skipped tests: 376
Affected tests: 9

Click here to see the affected service packages

All service packages are affected

Action taken

Found 9 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
• TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
• TestAccFirebaseHostingChannel_firebasehostingChannelUpdate
• TestAccFirebaseHostingSite_firebasehostingSiteBasicExample
• TestAccFirebaseHostingSite_firebasehostingSiteFullExample
• TestAccFirebaseHostingSite_firebasehostingSiteUpdate
• TestAccFirebaseHostingVersion_firebasehostingVersionCloudFunctionsExample
• TestAccSecurityCenterV2ProjectNotificationConfig_sccV2ProjectNotificationConfigBasicExample
• TestAccSecurityCenterV2ProjectNotificationConfig_updateStreamingConfigFilter

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccFirebaseHostingChannel_firebasehostingChannelUpdate[Debug log]
TestAccFirebaseHostingSite_firebasehostingSiteBasicExample[Debug log]
TestAccFirebaseHostingSite_firebasehostingSiteFullExample[Debug log]
TestAccFirebaseHostingSite_firebasehostingSiteUpdate[Debug log]
TestAccFirebaseHostingVersion_firebasehostingVersionCloudFunctionsExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccSecurityCenterV2ProjectNotificationConfig_sccV2ProjectNotificationConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2ProjectNotificationConfig_updateStreamingConfigFilter[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[vijaykanthm]

Hey @BBBmau, can you please approve the trigger to run the next steps. Thanks.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 14 files changed, 1028 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 12 files changed, 1018 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

[modular-magician]

Tests analytics

Total tests: 3825
Passed tests: 3443
Skipped tests: 378
Affected tests: 4

Click here to see the affected service packages

All service packages are affected

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccAppEngineFlexibleAppVersion_update
• TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy
• TestAccSecurityCenterV2ProjectNotificationConfig_sccV2ProjectNotificationConfigBasicExample
• TestAccSecurityCenterV2ProjectNotificationConfig_updateStreamingConfigFilter

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccAppEngineFlexibleAppVersion_update[Error message] [Debug log]
TestAccComputeInstanceNetworkIntefaceWithSecurityPolicy[Error message] [Debug log]
TestAccSecurityCenterV2ProjectNotificationConfig_sccV2ProjectNotificationConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2ProjectNotificationConfig_updateStreamingConfigFilter[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[github-actions]

@BBBmau This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

[github-actions]

@vijaykanthm, this PR is waiting for action from you. Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

If no action is taken, this PR will be closed in 28 days.

This notification can be disabled with the disable-automatic-closure label.

[vijaykanthm]

Hi @BBBmau, can you please approve the trigger so that CI will continue the next steps. Thanks.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1030 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1020 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

[modular-magician]

Tests analytics

Total tests: 6
Passed tests: 4
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• securitycenterv2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSecurityCenterV2ProjectNotificationConfig_sccV2ProjectNotificationConfigBasicExample
• TestAccSecurityCenterV2ProjectNotificationConfig_updateStreamingConfigFilter

Get to know how VCR tests work

[modular-magician]

$\textcolor{green}{\textsf{Tests passed during RECORDING mode:}}$
TestAccSecurityCenterV2ProjectNotificationConfig_sccV2ProjectNotificationConfigBasicExample[Debug log]

$\textcolor{green}{\textsf{No issues found for passed tests after REPLAYING rerun.}}$

---

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterV2ProjectNotificationConfig_updateStreamingConfigFilter[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 998 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 988 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_scc_v2_project_notification_config (3 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_scc_v2_project_notification_config" "primary" {
  project_id = # value needed
}

[modular-magician]

Tests analytics

Total tests: 7
Passed tests: 5
Skipped tests: 0
Affected tests: 2

Click here to see the affected service packages

• securitycenterv2

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccSecurityCenterV2ProjectNotificationConfig_sccV2ProjectNotificationConfigBasicExample
• TestAccSecurityCenterV2ProjectNotificationConfig_updateStreamingConfigFilter

Get to know how VCR tests work

[modular-magician]

$\textcolor{red}{\textsf{Tests failed during RECORDING mode:}}$
TestAccSecurityCenterV2ProjectNotificationConfig_sccV2ProjectNotificationConfigBasicExample[Error message] [Debug log]
TestAccSecurityCenterV2ProjectNotificationConfig_updateStreamingConfigFilter[Error message] [Debug log]

$\textcolor{red}{\textsf{Errors occurred during RECORDING mode. Please fix them to complete your PR.}}$

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 8 files changed, 1032 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 6 files changed, 1022 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

[modular-magician]

Tests analytics

Total tests: 7
Passed tests: 7
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• securitycenterv2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[BBBmau]

Was able to take one last in-depth review of this now that tests are passing, these involve checking that the docs and PR match.

I noticed that streamingConfig is not marked as required, but based on the purpose of this new resource it's safe to assume that this streamingConfig is necessary.

[BBBmau]

Looking over the docs, it looks like it shouldn't be marked as required. Is their other documentation that supports having it be set to required? docs: https://cloud.google.com/security-command-center/docs/reference/rest/v2/projects.locations.notificationConfigs

[vijaykanthm]

I don't think there is any other documentation and the current documentation also are vague which doesn't explicitly mention if they are required or not. Based on other contemporary config files I have put it as required, I can remove the field. Let me know if I can remove it.

[BBBmau]

Let's remove it so that it matches the documentation.

[vijaykanthm]

Removed.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 7 files changed, 1023 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 6 files changed, 1022 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 108 insertions(+))

[modular-magician]

Tests analytics

Total tests: 12
Passed tests: 12
Skipped tests: 0
Affected tests: 0

Click here to see the affected service packages

• securitycenterv2

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[BBBmau]

I appreciate your patience in regards to the requested changes, all looks good now!