Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation message for google_project.skip_delete #11397

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

rileykarson
Copy link
Member

Quick deprecation message update after #11359 as updating within 5.X is possible.

fyi @abd-goog @zli82016

Release Note Template for Downstream PRs (will be copied)

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 6 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 2 files changed, 6 insertions(+), 3 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_project (887 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_project" "primary" {
  skip_delete = # value needed
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 144
Passed tests: 114
Skipped tests: 30
Affected tests: 0

Click here to see the affected service packages
  • resourcemanager

$\textcolor{green}{\textsf{All tests passed!}}$

View the build log

Copy link
Member

@zli82016 zli82016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants