Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecation message for google_project.skip_delete #11397

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Update deprecation message for google_project.skip_delete #11397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fe2eae
Update deprecation message for skip_delete
rileykarson Aug 8, 2024
7431894
Update google_project.html.markdown
rileykarson Aug 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mmv1/third_party/terraform/services/resourcemanager/resource_google_project.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func ResourceGoogleProject() *schema.Resource {
},
"skip_delete": {
Type: schema.TypeBool,
Deprecated: `skip_delete is deprecated and will be removed in a future major release. The new release adds support for deletion_policy instead.`,
Deprecated: `skip_delete is deprecated and will be removed in 6.0.0. Please use deletion_policy instead. A skip_delete value of false can be changed to a deletion_policy value of DELETE and a skip_delete value of true to a deletion_policy value of ABANDON for equivalent behavior.`,
Optional: true,
Computed: true,
Description: `If true, the Terraform resource can be deleted without deleting the Project via the Google API.`,
Expand Down
7 changes: 5 additions & 2 deletions mmv1/third_party/terraform/website/docs/r/google_project.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,11 @@ The following arguments are supported:
See [Google Cloud Billing API Access Control](https://cloud.google.com/billing/docs/how-to/billing-access)
for more details.

* `skip_delete` - (Optional) If true, the Terraform resource can be deleted
without deleting the Project via the Google API. `skip_delete` is deprecated and will be removed in a future major release. The new release adds support for `deletion_policy` instead.
* `skip_delete` - (Optional) If true, the Terraform resource can be deleted without
deleting the Project via the Google API. `skip_delete` is deprecated and will be
removed in 6.0.0. Please use deletion_policy instead. A `skip_delete` value of `false`
can be changed to a `deletion_policy` value of `DELETE` and a `skip_delete` value of `true`
to a `deletion_policy` value of `ABANDON` for equivalent behavior.

* `labels` - (Optional) A set of key/value label pairs to assign to the project.
**Note**: This field is non-authoritative, and will only manage the labels present in your configuration.
Expand Down
Loading