Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2022-01-14 #7235

Closed
66 tasks done
OSBotify opened this issue Jan 14, 2022 · 18 comments
Closed
66 tasks done

Deploy Checklist: New Expensify 2022-01-14 #7235

OSBotify opened this issue Jan 14, 2022 · 18 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jan 14, 2022 •
edited by roryabraham
Loading

Release Version: 1.1.30-3
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jan 15, 2022
@mvtglobally
Copy link

Starting QA

@mvtglobally
Copy link

Regression is almost done
#6971 is failing due to #5699. Checking off as its KI
#7125 is failing due to #7258
#7197 is failing due to #7261. Checking off as its not a Blocker
#7226 is failing due to #7262. Checking off as its not a Blocker
#7227 is failing due to #7260.

@chiragsalian
Copy link
Contributor

chiragsalian commented Jan 17, 2022 •
edited
Loading

What's the status on testing #7222?
I noticed it was unchecked above.

Also it looks like #6856 has an update that it can be retested.

and can you retest #7267 when you get the chance.

@mvtglobally
Copy link

@chiragsalian We are re-testing and I will update shortly

@mvtglobally
Copy link

@chiragsalian We are unable to validate fix #7277 for 7267 as Android build 1.1.30-1 is still not available

@mvtglobally
Copy link

#7222 is failing #7222 (comment)

@mvtglobally
Copy link

Still no Android build for 1.1.30-1.

@mvtglobally
Copy link

mvtglobally commented Jan 18, 2022 •
edited
Loading

Let push to close this checklist today.
#7125. #7258 (7255) is fixed on all platforms but Android. We are still waiting a build to check.
#7227 is failing due to #7260. It doesn't seem to be a blocker. Checking off.
And left comment for #6856 (comment)

@chiragsalian
Copy link
Contributor

Cool, i've hit up my team and we're discussing about the android issue. We'll let you know once we figure it out.

@roryabraham
Copy link
Contributor

Since @chiragsalian is leading an interview today, I'll see what I can do to push this checklist forward today.

@mvtglobally
Copy link

@roryabraham we got 1.1.30-3 on Android. Team is checking CPs

@roryabraham
Copy link
Contributor

Checking of #7222 as per #7222 (comment)

@mvtglobally
Copy link

Checking off #7125. #7258. & #7277 for #7267 Android retest are pass
This is a new one #7228 Should we test? @roryabraham

@roryabraham
Copy link
Contributor

This is a new one #7228 Should we test?

Yes please!

@roryabraham
Copy link
Contributor

Any update?

@mvtglobally
Copy link

logging 1 minor issue and almost done

@mvtglobally
Copy link

@roryabraham #7293 and PR seem pass. Can you take a look and checkoff?
After this we are good to 🚀

@roryabraham
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@chiragsalian @applausebot @mvtglobally @roryabraham @OSBotify