Resolve missing Onfido dependency #6773

Julesssss · 2021-12-15T16:09:44Z

Details

Resolve issue where Onfido dependency was missing as BinTray has closed down

Also resolves a similar issue with Firebase libraries

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/188764
$ #7190

Tests

Make sure that you clear pods when building to iOS

ENSURE THE ANDROID RELEASE BUILD COMPILES (Android only)

Copy the .env.production contents into your .env file
Make sure you run npm i from the root App folder
Open the App/android folder in Android Studio
In Android Studio, click 'Build' > 'Clean project, or run ./gradlew clean from the android folder
In Android Studio, open the Build Variant window and select release
Wait for Gradle to Sync
Generate a signed release build via Build > Generate Signed Bundle / APK, then APK (you will need to create a new on-time keystore and can delete it afterwards)
The APK file should generate successfully
cd to that folder, then run adb install -r app-release.apk
App should run and work as expected

ENSURE THE ONFIDO LIBRARY UPDATE DIDN'T BREAK ONFIDO (Android & iOS)

Can be either release OR debug flavour
Build to iOS / Android (physical if possible, as Onfido requires hardware camera)
Create or navigate to a workspace, then scroll to 'Connect Bank Account'
Follow this StackOverflow, adding a verifying bank account
Ensure you can upload photos as part of the identity check flow
Arrive at the Additional Information (or Let's finish in chat! if you want to fully complete the VBA flow)

QA Steps

Run the ENSURE THE ONFIDO LIBRARY UPDATE DIDN'T BREAK ONFIDO test only.

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

…pendency

aldo-expensify · 2021-12-20T18:55:46Z

Hey @Julesssss ! do you know what I may be missing to test this?

Is this the menu entry you are referring to? Do you know why it may be greyed out in my case?

…ependencies

Julesssss · 2021-12-20T20:59:32Z

Is this the menu entry you are referring to? Do you know why it may be greyed out in my case?

Hey @aldo-expensify, I believe it's because you opened the root App folder in Android Studio. Try opening the App/android folder and see if you get the option.

(I just added some more changes too, but that shouldn't have changed anything)

aldo-expensify · 2021-12-20T21:18:57Z

Is this the menu entry you are referring to? Do you know why it may be greyed out in my case?

Hey @aldo-expensify, I believe it's because you opened the root App folder in Android Studio. Try opening the App/android folder and see if you get the option.

Hmm, nop, I opened it from the App/android folder:

Maybe I have something miss-configured in my env. Is it necessary to do the test using Android Studio? I can see the following in my event log:

2021-12-20
6:17 p.m.	Gradle sync started

6:17 p.m.	Android Studio is using the following JDK location when running Gradle:
				/Applications/Android Studio.app/Contents/jre/jdk/Contents/Home
				Using different JDK locations on different processes might cause Gradle to
				spawn multiple daemons, for example, by executing Gradle tasks from a terminal
				while using Android Studio.
				More info...
				Select a JDK from the File System
				Do not show this warning again

6:17 p.m.	Gradle sync failed: Sync failed: reason unknown (39 s 729 ms)

aldo-expensify · 2021-12-20T21:21:39Z

I'll try this.. https://stackoverflow.com/c/expensify/questions/8290

android/app/build.gradle

package.json

Julesssss · 2021-12-21T12:22:13Z

@aldo-expensify the second screenshot looks better, it looks like the file structure is now being recognized as a project.

That Stack Overflow isn't the solution (yet). Forget the release build for now. The first step is to be able to build successfully the default debug flavour. Once you can successfully generate a build (no need to run/install it), then you can worry about the release build (and follow the Stack Overflow).

The fact that the make project option is disabled tells me that Android Studio is still not configured correctly. Could you try some of the following and let me know how it goes? I can video chat at some point too if this doesn't help:

Run npm i again in the root App folder
File > Sync project with gradle files
Try clicking Add Configuration, as that should have defaulted to something
TryFile > Invalidate cache and Restart
Open the Problems & Event Log windows, and take a screenshot of any errors

Julesssss · 2021-12-21T14:44:16Z

@marcaaron I took a look through our test cases but couldn't find any related to Onfido/identity checks. Did I miss any, or do we not QA this currently?

I also tried following these steps, but was unable to work out how to get access to the Onfido dashboard. Seeking help in Slack....

Julesssss · 2021-12-21T15:46:14Z

I have to give up on Onfido for now, as I'm struggling to make progress and have external dependencies to work on instead. I have asked for help in engineering-chat here.

aldo-expensify · 2021-12-21T19:27:29Z

@Julesssss About my miss-configured environment... I fixed the error Gradle sync failed: Sync failed: reason unknown by changing the Android Gradle Plugin Version to 4.2.2. (File > Project Structure > Android Gradle Plugin Version) - more about it in this SO

With that change, the gradle sync finishes without throwing the error and now I can see more stuff in the menu NOT greyed out:

Also I noticed that the Build Variants panel can be accessed from Project Structure (maybe I have a different version of Android Studio.

Julesssss · 2021-12-22T18:18:34Z

I'm still struggling to test Onfido, currently stuck with an API error at the verify amounts step of the VBA flow. I have updated all repos and have Ngrok secure running 😭

VBAMissingexternalAPIResponse.mov

@aldo-expensify, please leave this for now. I'll have to try again in the new year.

marcaaron · 2022-01-11T00:01:34Z

What's the status of this PR?

Julesssss · 2022-01-11T12:06:37Z

@marcaaron an external dependency project took priority over this, but that was merged today so I'm back onto this issue. The only blocker here was that I have been unsuccessful in testing Onfido on dev. Will try again today and post my results.

Julesssss · 2022-01-11T15:24:21Z

Okay, I was able to verify the Onfido flow today on both physical iOS and Android devices. Thanks for the help @marcaaron!

@aldo-expensify sorry for the delay, the PR is now ready for testing. I have updated both tests, please let me know if you need any help with testing.

Julesssss · 2022-01-13T12:11:41Z

Bumping this for review, let me know if I can help with anything.

aldo-expensify

Tested release build on Android device, worked fine!
Tested on IOS simulator, Onfido opened fine, I didn't continue because of camera reasons.

Julesssss · 2022-01-13T18:06:52Z

CC @marcaaron you left comments in the last review, so it would be great to resolve those before we merge.

Jag96

LGTM, can confirm I'm no longer getting the bom issue when running npm run android-build locally

marcaaron · 2022-01-13T19:30:33Z

Thanks! The only comment I saw unresolved was a "just curious" so NAB if everything's testing good for y'all

Julesssss · 2022-01-14T12:08:30Z

Thanks all!

OSBotify · 2022-01-14T12:09:04Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2022-01-14T20:00:38Z

🚀 Deployed to staging by @Julesssss in version: 1.1.29-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2022-01-18T22:03:10Z

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Julesssss self-assigned this Dec 15, 2021

add mavenCentral to resolve missing dependency

42411d1

Julesssss force-pushed the jules-fixBrokenOnfidoDependency branch from 73d56f2 to 42411d1 Compare December 15, 2021 17:42

Julesssss added 2 commits December 20, 2021 13:32

bump Onfido & Firebase version, to resolve missing release flavour de…

f755b20

…pendency

add mavenCentral as a library repository, to repalce BinTray

b9de4cb

Julesssss marked this pull request as ready for review December 20, 2021 16:07

Julesssss requested a review from a team as a code owner December 20, 2021 16:07

MelvinBot requested review from aldo-expensify and removed request for a team December 20, 2021 16:08

Julesssss added 3 commits December 20, 2021 20:19

update Onfido library, to remove BinTray dependency

31e1195

fix 'More than one file was found with OS independent path' build issue

67e82be

remove mavenCentral repository, as it's not yet required for native d…

a831df4

…ependencies

Julesssss mentioned this pull request Dec 20, 2021

Icon rounding issue resolved #6770

Merged

1 task

marcaaron reviewed Dec 21, 2021

View reviewed changes

android/app/build.gradle Show resolved Hide resolved

package.json Show resolved Hide resolved

update pod files after Onfido library bump

603ebce

Merge branch 'main' into jules-fixBrokenOnfidoDependency

a3209e4

Julesssss added 2 commits January 11, 2022 14:25

Merge branch 'main' into jules-fixBrokenOnfidoDependency

02b192e

update iOS Onfido pod

736dea1

Julesssss changed the title ~~[NOQA] Resolve missing Onfido dependency~~ Resolve missing Onfido dependency Jan 11, 2022

rerun pod install after updating local cocoapods version

117fc61

Julesssss mentioned this pull request Jan 13, 2022

[Tracking] Deprecate jCenter in build.gradle #7190

Closed

aldo-expensify approved these changes Jan 13, 2022

View reviewed changes

Jag96 approved these changes Jan 13, 2022

View reviewed changes

Julesssss merged commit ca085ae into main Jan 14, 2022

Julesssss deleted the jules-fixBrokenOnfidoDependency branch January 14, 2022 12:08

OSBotify mentioned this pull request Jan 14, 2022

Deploy Checklist: New Expensify 2022-01-14 #7235

Closed

66 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Resolve missing Onfido dependency #6773

Resolve missing Onfido dependency #6773

Julesssss commented Dec 15, 2021 •

edited

Loading

aldo-expensify commented Dec 20, 2021

Julesssss commented Dec 20, 2021

aldo-expensify commented Dec 20, 2021

aldo-expensify commented Dec 20, 2021

Julesssss commented Dec 21, 2021 •

edited

Loading

Julesssss commented Dec 21, 2021

Julesssss commented Dec 21, 2021

aldo-expensify commented Dec 21, 2021

Julesssss commented Dec 22, 2021 •

edited

Loading

marcaaron commented Jan 11, 2022

Julesssss commented Jan 11, 2022

Julesssss commented Jan 11, 2022

Julesssss commented Jan 13, 2022

aldo-expensify left a comment •

edited

Loading

Julesssss commented Jan 13, 2022

Jag96 left a comment

marcaaron commented Jan 13, 2022

Julesssss commented Jan 14, 2022

OSBotify commented Jan 14, 2022

OSBotify commented Jan 14, 2022

OSBotify commented Jan 18, 2022

Resolve missing Onfido dependency #6773

Resolve missing Onfido dependency #6773

Conversation

Julesssss commented Dec 15, 2021 • edited Loading

Details

Fixed Issues

Tests

QA Steps

Tested On

Screenshots

Web

Mobile Web

Desktop

iOS

Android

aldo-expensify commented Dec 20, 2021

Julesssss commented Dec 20, 2021

aldo-expensify commented Dec 20, 2021

aldo-expensify commented Dec 20, 2021

Julesssss commented Dec 21, 2021 • edited Loading

Julesssss commented Dec 21, 2021

Julesssss commented Dec 21, 2021

aldo-expensify commented Dec 21, 2021

Julesssss commented Dec 22, 2021 • edited Loading

marcaaron commented Jan 11, 2022

Julesssss commented Jan 11, 2022

Julesssss commented Jan 11, 2022

Julesssss commented Jan 13, 2022

aldo-expensify left a comment • edited Loading

Choose a reason for hiding this comment

Julesssss commented Jan 13, 2022

Jag96 left a comment

Choose a reason for hiding this comment

marcaaron commented Jan 13, 2022

Julesssss commented Jan 14, 2022

OSBotify commented Jan 14, 2022

OSBotify commented Jan 14, 2022

OSBotify commented Jan 18, 2022

Julesssss commented Dec 15, 2021 •

edited

Loading

Julesssss commented Dec 21, 2021 •

edited

Loading

Julesssss commented Dec 22, 2021 •

edited

Loading

aldo-expensify left a comment •

edited

Loading