[NO QA] Fix tests/unit/getPullRequestsMergedBetweenTest.sh
#7134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roryabraham
previously approved these changes
Jan 12, 2022
|
@AndrewGable While testing this you might have messed up your commit signing:
|
MariaHCD
previously approved these changes
Jan 12, 2022
|
lol nice catch, I did turn off signing! Fix incoming shortly |
AndrewGable
dismissed stale reviews from MariaHCD and roryabraham
via
cb0f48b
AndrewGable
force-pushed
the
andrew-sign-test
branch
from
294a911 to
cb0f48b
Compare
|
Ok first time doing a signed rebase, but I think it all worked! |
roryabraham
approved these changes
Jan 13, 2022
|
Thanks again for figuring this out! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
66 tasks
|
🚀 Deployed to staging by @roryabraham in version: 1.1.29-6 🚀
|
|
🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The
-Sflag was causing cherry picks to be signed, we can safely remove the flag and the tests will still be effective.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/191675
Tests
QA Steps
N/A - Unit test, no code changes