fix: Search Page Order

[parasharrajat]

Details

Fixed Issues

$ #6627
$ #5699

Tests | QA Steps

1. Open Search Page.

2. Search for some user name that does not start with #.

3. Search results should be in the following order:

4. 1: 1 chat.

5. group Chat.

6. Room.

7. Order will change based on the resemblance between search value and search result. e.g. If the search value matches the room name, the room name would be above. etc.

---

1. In an account that has at least 1 workspace
2. Open search
3. Search for #announce room
4. Delete a character and write it again
5. room name should not duplicate

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web | Desktop

output_file.mp4

Mobile Web

iOS

Android

[roryabraham]

Sorry for the delay here. Reviewing now...

[roryabraham]

Looks good – my only suggestion is that we should order rooms so that any (deleted) rooms appear after open rooms.

[roryabraham]

We can do that pretty easily by replacing this line with:

let orderedReports = lodashOrderBy(reports, sortProperty, sortDirection);
orderedReports = _.sortBy(orderedReports, report => ReportUtils.isArchivedRoom(report));

[parasharrajat]

@roryabraham Updated.

[OSBotify]

🚀 Deployed to staging by @roryabraham in version: 1.1.29-8 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

[kavimuru]

@parasharrajat Issue #5699 is still reproduced. This PR is failing.

[parasharrajat]

@kavimuru Could you please follow these steps for me and share the results?

1. Open first announce room.
2. Save the id from URL and send one message to it.
3. Go back to some other chat but not any of these rooms.
4. Search for # announce and then open the second one.
5. Note the id and tell me if you see the same message again.

[parasharrajat]

@mvtglobally Any luck above?

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[kavimuru]

@parasharrajat Sorry for the delay. Issue #5699 is not reproduced anymore. I followed these steps and not seeing the same message.

1. Open first announce room.
2. Save the id from URL and send one message to it.
3. Go back to some other chat but not any of these rooms.
4. Search for # announce and then open the second one.
5. Note the id and tell me if you see the same message again.

Recording.153.mp4

[parasharrajat]

Thanks for looking into this @kavimuru. Based on these, I can say that these are two rooms with the same name. I saw the same results but as the message is not visible in the other rooms it means that they are different. Also, the id is different on URL.

It may be possible that these were created during the early development of Rooms so they have the same names.

Another fact is that only rooms with # announce name is shown twice which I suppose are auto-created.

It could be a good question to ask the team if two auto-generated rooms can have the same name. Sound like a bug but not related to this issue?

[jasperhuangg]

Hey! I know this is from a while back, but it looks like this PR is somewhat related to this bug. In addition to updating the indexOffset for that new section that you added, we also need to update the indexOffset for the usersToInvite section. The PR with that fix is here.