[HOLD for payment 2022-12-02] New Chat - When a username has numbers, multiple names are highlighted in the search

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to https://staging.new.expensify.com/
2. Login with any account
3. Click on the "Global action" button
4. Click on "New Chat"
5. Search for a user with numbers in their name
6. Verify that the first result in the list is highlighted

Expected Result:

The first result in the list is highlighted, and that the user can navigate up and down from there using the arrow keys.

Actual Result:

Multiple names are highlighted in the search, when a username has numbers.

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web
• iOS
• Android
• Desktop App
• Mobile Web

Version Number: 1.2.29.6

Reproducible in staging?: Yes

Reproducible in production?: Yes

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug5827612_Recording__116.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @arielgreen (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[jasperhuangg]

Gonna investigate this one

[jasperhuangg]

It seems our logic here doesn't take into account the userToInvite option that's added on here. Looking into a fix

[jasperhuangg]

We're setting indexOffset for each section incorrectly here, PR incoming...

[thesahindia]

I had reported this at #expensify-open-source

[jasperhuangg]

@arielgreen can we be sure to get @thesahindia the reporting bonus?

[arielgreen]

Of course!

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.2.31-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix multiple options getting selected on SearchPage, NewGroupPage #12906

If no regressions arise, payment will be issued on 2022-12-02. 🎊

After the hold period, please check if any of the following need payment for this issue, and if so check them off after paying:

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@jasperhuangg] The PR that introduced the bug has been identified. Link to the PR: fix: Search Page Order #6971
• [@jasperhuangg] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment: fix: Search Page Order #6971 (comment)
• [@jasperhuangg] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion: I don't think this is necessary; the issue didn't account for this so there wasn't anything technically wrong with the process, we just simply weren't aware of the bug so we didn't know to test for it.
• [@arielgreen] A regression test has been added or updated so that the same bug will not reach production again. Link to the GH issue for creating the test here: https://github.com/Expensify/Expensify/issues/248249

[arielgreen]

Payment issued.

[arielgreen]

Discussing proposed regression test here.

[arielgreen]

Added a test here: https://github.com/Expensify/Expensify/issues/248249