[CP Staging] Fix document upload on Android

[kidroca]

@mountiny

Details

Add file:// scheme prefix to attachment files (when it's missing)
Related to: #4908 (comment)

RN Document picker does not add a URI scheme for the file uri on Android. This seems to work ok for showing the document in previews, but instantly fails File upload when file:// is missing

Checked on iOS and there we do have a file:// prefix
So the logic that adds the prefix is conditional
Maybe we should try to address this on RN document picker's repo - this PR would remove the deploy blocker in the meantime

Fixed Issues

$ #7267

Tests

• Verify that no errors appear in the JS console
• Add a Document attachment in Android (verify it gets uploaded)
• Add a Document attachment in iOS (verify it gets uploaded)
• Add a Document attachment on other platforms (verify it gets uploaded)

QA Steps

Same as above

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

New.Expensify.-.Google.Chrome.2022-01-17.12-54-35.mp4

Mobile Web

Screen.Recording.2022-01-17.at.13.07.03.mov

Desktop

Screen.Recording.2022-01-17.at.13.00.04.mov

iOS

Screen.Recording.2022-01-17.at.12.32.24.mov

Android

Android.Emulator.-.Pixel_2_API_29_5554.2022-01-17.12-40-31.mp4

[mountiny]

Great! Thank you for fixing this deploy blocker. I agree this would be better to fix in the RN Attachment picker.

[github-actions]

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

[OSBotify]

🚀 Cherry-picked to staging by @mountiny in version: 1.1.30-1 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

[kidroca]

Great! Thank you for fixing this deploy blocker. I agree this would be better to fix in the RN Attachment picker.

I've opened an issue here: react-native-documents/document-picker#526
I guess it would be OK if we can open a PR about it

[mountiny]

Thank you for following up with the issue. It would be great if the fix could be implemented in the package itself. Would you be able to also create the PR? Do you need me to create a separate issue in our repo so you could be paid for it or can you just add time spent on that to this issue?

[kidroca]

Thank you for following up with the issue. It would be great if the fix could be implemented in the package itself. Would you be able to also create the PR? Do you need me to create a separate issue in our repo so you could be paid for it or can you just add time spent on that to this issue?

You're welcome

I've identified the cause react-native-documents/document-picker#526 (comment) and I can submit a PR
I can time track it and log it under #7267
Can you add me there (but remove the deploy blocker label)?

[mountiny]

Done @kidroca! Thank you!

[OSBotify]

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅