Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default text for User-Created Policy Rooms #7197

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

luacmartins
Copy link
Contributor

@luacmartins luacmartins commented Jan 13, 2022

Details

Copy change for default user created policy rooms.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/176855

Tests

  1. Click the '+' icon and select New room
  2. Create a restricted room and verify that the welcome text reads: This is the beginning of #roomname, invite others by @mentioning them
  3. Create a private room and verify that the welcome text reads: This is the beginning of the private #roomname room, invite others by @mentioning them
  4. Create a chat with another user you haven't chatted with before and verify that the welcome text reads: This is the beginning of your chat history with <user name>.

QA Steps

Steps above.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web1
web2
web3

Mobile Web

mweb1
mweb2
mweb3

Desktop

desktop1

desktop2

desktop3

iOS

ios1
ios2
ios3

Android

android1
android2
android3

@luacmartins luacmartins self-assigned this Jan 13, 2022
@luacmartins
Copy link
Contributor Author

While testing, I noticed inconsistencies with the avatar icon not showing up. Since that's rendered by another component and not part of this PR, I'd create a separate issue for that.

@luacmartins luacmartins marked this pull request as ready for review January 13, 2022 19:26
@luacmartins luacmartins requested a review from a team as a code owner January 13, 2022 19:26
@MelvinBot MelvinBot requested review from Gonals and removed request for a team January 13, 2022 19:27
@Gonals Gonals merged commit a445c5b into main Jan 14, 2022
@Gonals Gonals deleted the cmartins-userPolicyRoomText branch January 14, 2022 16:57
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by @Gonals in version: 1.1.29-6 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 failure ❌
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by @roryabraham in version: 1.1.30-3 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants