Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Policy room - Able to create room with same name and no error appears #7260

Closed
kavimuru opened this issue Jan 15, 2022 · 8 comments
Closed
Assignees
Labels
Daily KSv2 Engineering Reviewing Has a PR in review

Comments

@kavimuru
Copy link

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing #7227

Action Performed:

  1. Go to https://staging.new.expensify.com/
  2. Create room e.g. Fish
  3. Create second room with same name Fish

Expected Result:

Error appears if you try to use the same name as an existing policy room in that same workspace.

Actual Result:

Able to create room with same name and no error appears

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platform:

Where is this issue occurring?

  • Web
  • iOS
  • Android
  • Desktop App
  • Mobile Web

Version Number: v1.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:

Bug5408669_fish.mp4

Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:

View all open jobs on GitHub

@MelvinBot
Copy link

Triggered auto assignment to @sketchydroide (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@sketchydroide
Copy link
Contributor

@TomatoToaster it seems you edited this code not that long ago do you know if this has been fixed?

@TomatoToaster
Copy link
Contributor

Ah I guess we should be surfacing an error. But actually I don't think this is a bug. A second room doesn't get created right, it just seems like it brings you back to the existing room which seems to be working as intended.

@TomatoToaster
Copy link
Contributor

@kavimuru could you verify that when you enter a message into that room and then try to create another room it doesn't try to give you a new one?

@TomatoToaster
Copy link
Contributor

Hmm it is weird it didn't show the error text though.

@kavimuru
Copy link
Author

@TomatoToaster It takes me to the same existing room when I enter a message and create another room. But no error message displayed

Recording.157.mp4

.

@TomatoToaster
Copy link
Contributor

Ahhh I see, the error isn't showing in the create room modal. Thanks for that clarification!

Hmm it is weird that the room is loaded, and you can see it even in the left hand nav, but it seems like the create a room modal is not comparing its title properly to know its a duplicate (only seems to happen right after creation too). Cool I think I have a lead on how to fix this bug, thanks!

@TomatoToaster
Copy link
Contributor

PR up for this badboy^ just need to test it

@TomatoToaster TomatoToaster added the Reviewing Has a PR in review label Jan 31, 2022
@MelvinBot MelvinBot removed the Overdue label Jan 31, 2022
@botify botify closed this as completed Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Daily KSv2 Engineering Reviewing Has a PR in review
Projects
None yet
Development

No branches or pull requests

5 participants