-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Policy room - Able to create room with same name and no error appears #7260
Comments
Triggered auto assignment to @sketchydroide ( |
@TomatoToaster it seems you edited this code not that long ago do you know if this has been fixed? |
Ah I guess we should be surfacing an error. But actually I don't think this is a bug. A second room doesn't get created right, it just seems like it brings you back to the existing room which seems to be working as intended. |
@kavimuru could you verify that when you enter a message into that room and then try to create another room it doesn't try to give you a new one? |
Hmm it is weird it didn't show the error text though. |
@TomatoToaster It takes me to the same existing room when I enter a message and create another room. But no error message displayed Recording.157.mp4. |
Ahhh I see, the error isn't showing in the create room modal. Thanks for that clarification! Hmm it is weird that the room is loaded, and you can see it even in the left hand nav, but it seems like the create a room modal is not comparing its title properly to know its a duplicate (only seems to happen right after creation too). Cool I think I have a lead on how to fix this bug, thanks! |
PR up for this badboy^ just need to test it |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Issue found when executing #7227
Action Performed:
Expected Result:
Error appears if you try to use the same name as an existing policy room in that same workspace.
Actual Result:
Able to create room with same name and no error appears
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platform:
Where is this issue occurring?
Version Number: v1.1.30-0
Reproducible in staging?: Yes
Reproducible in production?: Yes
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
Bug5408669_fish.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: