Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Release with upstream k8s-extension/public #107

Merged
merged 169 commits into from
Mar 11, 2022
Merged

Update Release with upstream k8s-extension/public #107

merged 169 commits into from
Mar 11, 2022

Conversation

jonathan-innis
Copy link

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

c-ryan-k and others added 30 commits January 3, 2022 12:11
@c-ryan-k
[IoT] IoT Extension release v0.12.1 (Azure#4287)
b308529 
* IoT Extension release v0.12.1
* Add linter exclusions
@iamsantoshmishra @sanmishra18 @zhoxing-ms
[connectedvmware] Added tags support and fix know bugs. (Azure#4264)
3bcc340 
* Added tags support and fix know bugs.

* Addressed reviewer comment.

* Update src/connectedvmware/azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py

* Update src/connectedvmware/azext_connectedvmware/tests/latest/test_arcvmware_scenario.py

* Addressed reviewer review comment.

* Removed test_arcvmware_scenario.py file.

* Run test to generate latest recording file.

Co-authored-by: Santosh Mishra <[email protected]>
Co-authored-by: Xing Zhou <[email protected]>
@bcho
[AKS] Implement --enable-oidc-issuer (Azure#4280)
c721194 
* feat: define new argument

* feat: construct oidc issuer profile from user input

* feat: bump version

* test: add unit tests

* test: add live tests

* fix: remove issuerUrl check

* test: add recordings

* doc: update history.md

* chore: exclude tests
@azclibot
[Release] Update index.json for extension [ aks-preview ] (Azure#4289)
f2a81bf 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1272281

Last commit: Azure@c721194
@azclibot
[Release] Update index.json for extension [ connectedvmware ] (Azure#…
f23a400 
…4288)

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1272036

Last commit: Azure@3bcc340
@yuwzho
[Spring-Cloud] refactor spring-cloud create (Azure#4291)
07d4ad5 
* [Spring-Cloud] refactor spring-cloud create

* add more tests

* group parameters

* add mock reset in setup
@ninpan-ms @zhoxing-ms
Add end to end logics for ACS, Service Registry, Gateway and API port…
97d7685 
…al (Azure#4282)

* Add end to end logics for ACS, Service Registry, Gateway and API portal

* fix linter

* fix linter

* fix linter

* Add unit tests

* Update scope

Co-authored-by: Xing Zhou <[email protected]>

* Update scope for ACS git repo

Co-authored-by: Xing Zhou <[email protected]>

* fix comment

* fix linter

* Update scope

Co-authored-by: Xing Zhou <[email protected]>

* fix comment

* Update _params.py

Co-authored-by: Xing Zhou <[email protected]>
@FumingZhang
update error handling (Azure#4283)
6ac7b05
@ravithanneeru @moirf @v-mausha
Azure CLI commands for communication (Azure#4206)
72de9b7 
* Azure CLI commands for communication

* Resolving lint and style errors

* Lint errors fix

* More descriptive about the communication commands

* Adding tests for communication extension

* Made changes for sanatization

* Incorporated review comments

* Azure CLI commands for communication

* Resolving lint and style errors

* Lint errors fix

* More descriptive about the communication commands

* Adding tests for communication extension

* Made changes for sanatization

* Incorporated review comments

* Removing hard coded ACS resource id

* Made changes to run the sample in playback mode

* Change azure_devtools with azure.cli.testsdk imports, as per latest azure-cli changes

* Add communication resource preparer in communication extension

* Add license information in preparers.py

* Updated the version and added rease history.
Updated the Readme file.

Co-authored-by: maulinasharma <[email protected]>
Co-authored-by: Mohammad Irfan <[email protected]>
Co-authored-by: maulinasharma <[email protected]>
Co-authored-by: Mohammad Irfan <[email protected]>
@zjpjack
make the aks show table output contain currentKubernetesVersion column (
906f96c 
Azure#4299)

* make the aks show table output contain currentKubernetesVersion column

* add more details for new release

Co-authored-by: Jianping Zeng <[email protected]>
@jonathan-innis @yuyue9284
@liakaz @nshankar13 @jingyizhu99 @tianchijushi @trstringer @NarayanThiru @nreisch @anagg929 @ZeroMagic @youhuatuyh @youhuatu-yh @mjaow
[k8s-extension] Release v1.0.4 with SSL secret support for AzureML (A…
d573b22 
…zure#4286)

* Create pull.yml

* Update pull.yml

* Update azure-pipelines.yml

* Initial commit of k8s-extension

* Update pipelines file

* Update CODEOWNERS

* Update private preview pipelines

* Remove open service mesh from public release

* Update pipeline files

* Update public extension pipeline

* Change condition variable

* Add version to public preview/private preview

* Update pipelines

* Add different testing based on private branch

* Add annotations to extension model

* Update k8s-custom-pipelines.yml

* Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13)

* Update sdks with updated swagger spec

* Update version and history rst

* Reorder release history timeline

* Fix ExtensionInstanceForCreate for import

* remove py2 bdist support

* Add custom table formatting

* Remove unnecessary files

* Fix style issues

* Fix branch based on comments

* Update identity piece manually

* Don't handle defaults at the CLI level

* Remove defaults from CLI client

* Check null target namespace with namespace scope

* Update style

* Add cassandra operator and location to model

* Stage Public Version of k8s-extension 0.2.0 for official release (#15)

* Create pull.yml

* Update pull.yml

* Update azure-pipelines.yml

* Initial commit of k8s-extension

* Update pipelines file

* Update CODEOWNERS

* Update private preview pipelines

* Remove open service mesh from public release

* Update pipeline files

* Update public extension pipeline

* Change condition variable

* Add version to public preview/private preview

* Update pipelines

* Add different testing based on private branch

* Add annotations to extension model

* Update k8s-custom-pipelines.yml

* Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13)

* Update sdks with updated swagger spec

* Update version and history rst

* Reorder release history timeline

* Fix ExtensionInstanceForCreate for import

* remove py2 bdist support

* Add custom table formatting

* Remove unnecessary files

* Fix style issues

* Fix branch based on comments

* Update identity piece manually

* Don't handle defaults at the CLI level

* Remove defaults from CLI client

* Check null target namespace with namespace scope

* Update style

* Add cassandra operator and location to model

Co-authored-by: [email protected] <Action - Fork Sync>

* Remove custom pipelines file

* Update extension description, remove private const

* Update pipeline file

* Disable refs docs

* Update to include better create warning logs and remove update context (#20)

* Update to include better create warning logs and remove update context

* Remove help text for update

* Fix spelling error

* Update message

* Fix k8s-extension conflict with private version

* Fix style errors

* Fix filename

* add customization for microsoft.azureml.kubernetes (#23)

* add customization for microsoft.azureml.kubernetes

* Update release history

Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: jonathan-innis <[email protected]>

* Add E2E Testing from Separate branch into internal code (#26)

* Add internal e2e testing

* Change to testing folder

* Inference CLI validation for Scoring FE (#24)

* cli validation starter

* added the call to the fe validation function

* nodeport validation not required

* test fix

Co-authored-by: Jonathan Innis <[email protected]>

* legal warning added (#27)

* Remove deprecated method logger.warn

* Update k8s-custom-pipelines.yml for Azure Pipelines

* Update k8s-custom-pipelines.yml for Azure Pipelines

* Add Azure Defender to E2E testing (#28)

* Add azure defender testing to e2e

* Remove the debug flag

* Add configuration testing

* Fix pipeline failures

* Make test script more intuitive

* Remove parameter from testing

* Fix wrong location for k8s config whl

* Fix pip upgrade issue

* Fix pip install upgrade issue

* Fix pip install issue

* delete resurce in testcase (#29)

Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: Jonathan Innis <[email protected]>

* Check Provider is Registered with Subscription Before Making Requests (#18)

* Add check for KubernetesConfiguration

* Disable pylint and rename

* Update provider registration link

* Update version

* Remove extra blank line

* Fix bug in import

* only validate scoring fe when inference is enabled (#31)

* only validate scoring fe when inference is enabled

* Fix versioning

Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: jonathan-innis <[email protected]>

* Provider registration case insensitive

* do not validate against scoring fe if inference is not enabled. (#33)

* do not validate against scoring fe if inference is not enabled.

* add inference enabled scenario

* refine

* increase sleeping time

* fix

Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: Jonathan Innis <[email protected]>

* Add OSM as Public Preview Extension (#34)

* Add OSM as public preview extension

* Add osm testing

* Add release train to tests

* Fix failing osm test

* Upgrade pip in integration testing

* Remove ununsed import

* Fix release train check in update

* Parallelize E2E Testing (#36)

* Add OSM as public preview extension

* Add osm testing

* Update test logic to parallelize

* Fix test success checking

* Parallelize extension testing

* Better error checking logic

* Fix azureml deletion

* Fix private build (#40)

* change amlk8s to amlarc (#42)

Co-authored-by: Yue Yu <[email protected]>

* Servicebus client model changes (#44)

* Servicebus client model changes

* Fix testing script

* Update history file and pipeline

* Update min cli core version for track 2 updates

* Read SSL cert and key from files (#38)

* first sketch of the change

fixes

removed extra blank lines

changes regarding param renaming

added ssl tests

added more detail to the unit test

additional import

moved pem files out of public folder

fixed import

chenged import

changed import

unit tests fix

unit test fix

fixed unit tests

fixed unit test

unit test fix

changes int test cert and key

* test protected config

* fix test typo

* temporary changes reverted

* fixing tests

* fixed file paths

* removed accidentally added file

* changes according to review comments

* more changes according to review comments

* changes according to review comments

Co-authored-by: Jonathan Innis <[email protected]>

* Upgrade release version

* Liakaz/inference read ssl from file (#47)

* first sketch of the change

fixes

removed extra blank lines

changes regarding param renaming

added ssl tests

added more detail to the unit test

additional import

moved pem files out of public folder

fixed import

chenged import

changed import

unit tests fix

unit test fix

fixed unit tests

fixed unit test

unit test fix

changes int test cert and key

* test protected config

* fix test typo

* temporary changes reverted

* fixing tests

* fixed file paths

* removed accidentally added file

* changes according to review comments

* more changes according to review comments

* changes according to review comments

* fixed decode error

* renamed the experimental param

Co-authored-by: Jonathan Innis <[email protected]>

* Fix style issues (#51)

* Fixed scoring fe related extension param names (#49)

* fixed scoring fe related extension params

* bug fix and style fixes

* variable rename

* fixed the error type

* set cluster to prod by default

* Add distro validation for osm-arc (#50)

* Add distro validation for osm-arc

* fixed indentation

* Fix linting

* Resolve comments

* Add unit test

* fix lint

Co-authored-by: Jonathan Innis <[email protected]>

* Add distro validation for osm-arc (#50)

* Add distro validation for osm-arc

* fixed indentation

* Fix linting

* Resolve comments

* Add unit test

* fix lint

Co-authored-by: Jonathan Innis <[email protected]>

* Add distro validation for osm-arc (#53)

removed release-train logic

* Add Custom Delete Logic for Partners (#54)

* Add custom delete logic

* Fix failing unit tests

* Add warning message when deleting amlarc extension (#55)

* add warning message

* fix indentation

* Update release version

* Remove Pyhelm from OSM customization (#58)

* Fix OSM pyhelm bug

* Debug bootstrap error

* Update release message

* Remove pyhelm dependency

* Update tests to only check extensionconfig creation (#61)

* Update tests to only check extensionconfig creation

* Single set of CRUD for AzureML

* Debug logs for connectedk8s

* Increase open service mesh version number

* Update k8s-extension Models to Track2 (#64)

* Update k8s-extension models to track2

* Add debug for failed cleanup

* Increase version number

* Exit 0 on failed cleanup

* Fix identity in wrong place in model (#66)

* Readd osm-arc distro validation (#62)

* Add distro validation for osm-arc

removed release-train logic

* Readd osm_arc distro validation

* Fix style

* Rm space

* Edit test

* Fixed tests and error logic

* Remove dependency

* Add delete method

Co-authored-by: Jonathan Innis <[email protected]>

* Don't Send Identity Headers If In DF (#67)

* Don't send identity for clusters in dogfood

* Add location to model for identity

* Add identity validation to testing

* Use default extension with identity instead of Cassandra specific (#69)

* Remove the identity check for now

* Add -t for clusterType parameter (#71)

* Adding a flag for AKS to AMLARC migration and set up corresponding FE… (#65)

* Adding a flag for AKS to AMLARC migration and set up corresponding FE helm values

* Remove one extra line

* Adding Scoring FE IS_AKS_MIGRATION check logic for helm values

Co-authored-by: Harry Yang <[email protected]>
Co-authored-by: Jonathan Innis <[email protected]>

* remove version requirement and auto upgrade minor version check (#72)

* Custom User Confirmation for Partners (#70)

* Custom user confirmation

* Check for disable confirm prompty for confirmation

* Add yes to delete command

* Code cleanup and style fixes (#73)

* Enabled identity by default (#74)

* Increase version

* Fix df check and add unit test (#77)

* Bump extension version

* Pin helm version

* Extensions GA changes into Public Branch (#79)

* Add openservicemesh back

* OpenServiceMesh import

* Update osm with new extension model

* Add back private file

* Add Azure ML to list of private extensions (#16)

* Update k8s-custom-pipelines.yml

* Add Microsoft.PolicyInsights extension (#17)

* Add Policy extension

* Update comment

* Update args

* Fix linting errors

Co-authored-by: Jonathan Innis <[email protected]>

* Add HISTORY_private file for private preview

* Change versioning scheme

* Update the code for supporting both extensions at once

* Fix style issue

* Remove old consts file

* change the resource tag from managed_by:amlk8s to created_by:amlk8s-e… (#22)

* change the resource tag from managed_by:amlk8s to created_by:amlk8s-extension

* remove the lock when creating resources

* fix lint

* update version and HISTORY_private.rst

* change error message

Co-authored-by: Yue Yu <[email protected]>

* Update the beta version with upstream

* Update the private history file

* Add upgrade pip to pipeline

* Move pip install within virtualenv

* Merge in k8s-extension/public (0.3.1) (#32)

* delete resurce in testcase (#29)

Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: Jonathan Innis <[email protected]>

* Check Provider is Registered with Subscription Before Making Requests (#18)

* Add check for KubernetesConfiguration

* Disable pylint and rename

* Update provider registration link

* Update version

* Remove extra blank line

* Fix bug in import

* only validate scoring fe when inference is enabled (#31)

* only validate scoring fe when inference is enabled

* Fix versioning

Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: jonathan-innis <[email protected]>

* Update private release

Co-authored-by: yuyue9284 <[email protected]>
Co-authored-by: Yue Yu <[email protected]>

* Release Version 0.4.0-b1 (#37)

* Merge k8s-extension/public into k8s-extension/private

* Update the version

* Fix testing concurrency

* K8s extension/private 0.4.0b2 (#41)

* Fix private build (#40)

* Update version

* Upgrade to v0.5.2

* Fix policy bug

* Increase private version

* Update consts_private.py

* Increase private version

* Increase version with public

* Add flux to private version

* Update models for 2021-05-01-preview

* Add async models to version

* Add no wait to delete and create

* support managed cluster

* Bump version

* Pin helm version

* Add cmd to delete call

* Add force deletion

* add dapr extension (#78)

Signed-off-by: Ji An Liu <[email protected]>

* Fix failing integration tests

* Adding the GA changes for private branch

* Fix confirm prompt

* Fix update E2E tests

Co-authored-by: jonathan-innis <[email protected]>
Co-authored-by: [email protected] <Action - Fork Sync>
Co-authored-by: nreisch <[email protected]>
Co-authored-by: yuyue9284 <[email protected]>
Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: anagg929 <[email protected]>
Co-authored-by: Ji'an Liu <[email protected]>
Co-authored-by: nanthi <nanthi@NANTHI01>

* Fix configuration settings in update

* Only provide confirmation when specifying settings

* Fix style issues

* Cassandra tests with update (#81)

* Add Microsoft.PolicyInsights extension for public preview (#83)

* Add Azure Policy

* Remove custom configuration and update tests

* Yuyu3/fix upgrade public (#85)

* populate configuration protected settings for azureml

bump version && add log

fetch connection string only if configuration protected settings are set

update ssl key

* bump the version

* reverse changes on version and HISTORY.rst

* inferenceLoadBalancerHA

Co-authored-by: Yue Yu <[email protected]>

* Remove Parallel Powershell Jobs (#82)

* Unparallelize tests

* Moved location of pipeline file

* Remove the parallel invoke expression calls

* Add templates to testing

* Remove policy update test from extension E2E (#88)

* feIsNodePort, feIsInternalLoadBalancer (#87)

Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: Jonathan Innis <[email protected]>

* Fix history file

* Add one more prompt for amlarc extension update (#94)

* Add one more prompt for amlarc extension update

* fix pylint issue

* fix pylint issue

* fix pylint issue

* fix pylint issue

Co-authored-by: Youhua Tu <[email protected]>
Co-authored-by: Youhua Tu <[email protected]>

* Update Identity Creation for Appliance to Latest Version (#95)

* Update appliance API to latest version for identity

* Create a utils file with get parent_api_version

* Fix style errors

* Bump version

* Remove additional entry from history

* Do not create identity with appliances (#97)

* Bump version

* support sslSecret (#99)

* support sslSecret

* fix

* fix error message

Co-authored-by: Jun Min <[email protected]>

* Bump version to 1.0.4

* Remove unneeded files

Co-authored-by: [email protected] <Action - Fork Sync>
Co-authored-by: yuyue9284 <[email protected]>
Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: Lia Kazakova <[email protected]>
Co-authored-by: Niranjan Shankar <[email protected]>
Co-authored-by: jingyizhu99 <[email protected]>
Co-authored-by: Harry Yang <[email protected]>
Co-authored-by: Harry Yang <[email protected]>
Co-authored-by: Thomas Stringer <[email protected]>
Co-authored-by: NarayanThiru <[email protected]>
Co-authored-by: nreisch <[email protected]>
Co-authored-by: anagg929 <[email protected]>
Co-authored-by: Ji'an Liu <[email protected]>
Co-authored-by: nanthi <nanthi@NANTHI01>
Co-authored-by: youhuatuyh <[email protected]>
Co-authored-by: Youhua Tu <[email protected]>
Co-authored-by: Youhua Tu <[email protected]>
Co-authored-by: Jun <[email protected]>
Co-authored-by: Jun Min <[email protected]>
@jonathan-innis @yuyue9284 @liakaz
[k8s-configuration] Release v1.4.0 with S3 Bucket as Source support (A…
1531a34 
…zure#4285)

* Create pull.yml

* Update pull.yml

* Update azure-pipelines.yml

* Initial commit of k8s-extension

* Update CODEOWNERS

* Update azure-pipelines.yml

* Create pull.yml

* Update pull.yml

* Update pull.yml

* Update pipelines file

* Update k8s-configuration name

* Update test script params

* Update pipeline file

* Remove codeowners

* Update pipelines file

* Update CODEOWNERS

* Update private preview pipelines

* Remove open service mesh from public release

* Update pipeline files

* Update custom pipelines files

* Add publish step to k8s-configuration

* Update pipeline to publish extension

* Update public extension pipeline

* Change condition variable

* Update pipeline naming

* Add version to public preview/private preview

* Update pipelines

* Add different testing based on private branch

* Add annotations to extension model

* Update k8s-custom-pipelines.yml

* Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13)

* Update sdks with updated swagger spec

* Update version and history rst

* Reorder release history timeline

* Fix ExtensionInstanceForCreate for import

* remove py2 bdist support

* Add custom table formatting

* Remove unnecessary files

* Fix style issues

* Fix branch based on comments

* Update identity piece manually

* Don't handle defaults at the CLI level

* Remove defaults from CLI client

* Check null target namespace with namespace scope

* Update style

* Add cassandra operator and location to model

* Stage Public Version of k8s-extension 0.2.0 for official release (#15)

* Create pull.yml

* Update pull.yml

* Update azure-pipelines.yml

* Initial commit of k8s-extension

* Update pipelines file

* Update CODEOWNERS

* Update private preview pipelines

* Remove open service mesh from public release

* Update pipeline files

* Update public extension pipeline

* Change condition variable

* Add version to public preview/private preview

* Update pipelines

* Add different testing based on private branch

* Add annotations to extension model

* Update k8s-custom-pipelines.yml

* Update SDKs with Updated Swagger Spec for 2020-07-01-preview (#13)

* Update sdks with updated swagger spec

* Update version and history rst

* Reorder release history timeline

* Fix ExtensionInstanceForCreate for import

* remove py2 bdist support

* Add custom table formatting

* Remove unnecessary files

* Fix style issues

* Fix branch based on comments

* Update identity piece manually

* Don't handle defaults at the CLI level

* Remove defaults from CLI client

* Check null target namespace with namespace scope

* Update style

* Add cassandra operator and location to model

Co-authored-by: [email protected] <Action - Fork Sync>

* Remove custom pipelines file

* Update extension description, remove private const

* Update pipeline file

* Disable check ref docs

* Disable refs docs

* Update to include better create warning logs and remove update context (#20)

* Update to include better create warning logs and remove update context

* Remove help text for update

* Fix spelling error

* Update message

* Fix k8s-extension conflict with private version

* Fix style errors

* Fix filename

* add customization for microsoft.azureml.kubernetes (#23)

* add customization for microsoft.azureml.kubernetes

* Update release history

Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: jonathan-innis <[email protected]>

* Add E2E Testing from Separate branch into internal code (#26)

* Add internal e2e testing

* Change to testing folder

* Inference CLI validation for Scoring FE (#24)

* cli validation starter

* added the call to the fe validation function

* nodeport validation not required

* test fix

Co-authored-by: Jonathan Innis <[email protected]>

* legal warning added (#27)

* Remove deprecated method logger.warn

* Update k8s-custom-pipelines.yml for Azure Pipelines

* Update k8s-custom-pipelines.yml for Azure Pipelines

* Add Azure Defender to E2E testing (#28)

* Add azure defender testing to e2e

* Remove the debug flag

* Add configuration testing

* Fix pipeline failures

* Make test script more intuitive

* Remove parameter from testing

* Add some debug

* Fix wrong location for k8s config whl

* Fix pip install upgrade issue

* Fix pip install upgrade issue

* Add Check for Provider Registration and Refactor (#19)

* Add check for provider registration and refactor

* Fix bug in checking registration

* Add license header to utils

* Update private key check and error messaging

* Update based on refactoring

* Fix failing tests

* Add provider registration check

* Create a test for uppercase url, address comments

* Add blank line to fix style check

* Testing increase to ubuntu-latest

* Update k8s-configuration Models to Track2 (#63)

* Update models to track2

* Increase k8s-configuration version number

* Update kind version

* Change error to warning because of DSA failure

* Upgrade helm operator chart version (#75)

* Pin helm version

* Bump version

* Migrate pipeline (#90)

* Disable updates on configuration tests (#89)

* Release k8s-configuration v1.2.0 for Flux v2 Public Preview (#86)

* Scaffold out the k8s-config package

* Base implementation of CLI commands

* Add create scenario and cleanup in consts

* Add help text to commands, params

* Add other clients to client factory

* Automatically installing the flux extension

* Move flux and extension into modules

* Updated the versioned sdks

* Push working command for testing

* Update to multi api versioned sdk

* Support other extension methods

* Fix nullity check

* Add source control provider

* Add scc commands

* Add defer logic for create with cache

* Use default extension with identity

* Fix identity creation

* Add kustomization caching

* Add formatters

* Add scc provider

* Add help text for k8s-config fluxv1

* Add help text for extension

* Allow force delete of extension and fluxconfiguration

* Add location to the extension model

* Update with latest from k8s-extension

* Add k8s-config testing

* Add license header

* Fix all style issues

* Update codeowners file

* Validate data before checking cluster compliance

* No kustomizations warning

* Fix identity issue in 2020-07-01

* Fix k8s regex

* Fix configuration name regex validation

* Fix name length validation

* Adding some validation warnings

* Add protected settings to request

* Exclude private test path

* Add suspend functionality

* Add correct values to build Kustomization

* Add no_wait

* Fix style issues

* Use base64 encoded httpsUser

* Fix formatting error and base64 encoding error

* Fix style issues

* Fix force

* Updated help text

* Style fixes

* Increase namespace maximum len

* Add managed cluster support to k8s-config

* Custom confirmation when prune is enabled

* Add flux commands to existing k8s-configuration

* Remove extension provider from CLI

* Fix style issues

* Override extension variables

* Strip newlines from known_hosts file

* Update help text and validators

* Strip newlines from known hosts

* Add provisioning state check for flux extension

* Pin helm version

* Remove validation from create command

* Add patch support with new SDK

* Add implementation for CRUD of source and kustomization

* Fix errors on patch

* Fix some bugs in patching properties

* Add fixes for patch in k8s-configuraiton

* Change duration formatting in table output

* Add validation and conversion for durations

* Bump verison and fix typo

* Fix bug with dependencies

* Fix linter and style issues

* Fix delete prune check

* Add flux testing

* Create separate jobs for scenarios

* Update error text

* Fix filepath suggestion from CLI team

* Fix unneeded file edit

* Add a Deployed Object List to the Flux CLI (#91)

* Enable a deployed object list on the CLI

* Show detail when extension install fails

* Bump version

* Update deployed object format (#93)

* Fix help text for consistency

* Enable Bucket Support in the CLI (#92)

* Update vendored_sdks

* Enable source kind generation factories and use kwargs to pass to provider

* Add better validation logic to source generator

* Move away from classes in the provider directory

* Fix style issues using black auto-formatter

* Fix linter failures

* Update identity with api version and rp in same function

* Bucket Testing for E2E Testing (#96)

* Bucket testing

* Add switching kind test to update CLI

* Bump version

* Remove unneeded files

Co-authored-by: [email protected] <Action - Fork Sync>
Co-authored-by: yuyue9284 <[email protected]>
Co-authored-by: Yue Yu <[email protected]>
Co-authored-by: Lia Kazakova <[email protected]>
add java 17 support (Azure#4293)
0a5d27b
@evelyn-ys
[storage-preview] Bump azure-mgmt-storage to 2021-08-01 (Azure#4093)
33d8ee7 
* Bump `azure-mgmt-storage` to 2021-08-01

* linter

* update SDK

* Update SDK

* update sdk
@yuwzho
[Spring-Cloud] Remove unused method (Azure#4279)
024e51b
@azclibot
[Release] Update index.json for extension [ k8s-extension ] (Azure#4307)
02eb263 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1284077

Last commit: Azure@d573b22
@azclibot
[Release] Update index.json for extension [ k8s-configuration ] (Azur…
671df3e 
…e#4306)

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1284078

Last commit: Azure@1531a34
@azclibot
[Release] Update index.json for extension [ aks-preview ] (Azure#4305)
1d434f4 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1284076

Last commit: Azure@906f96c
@azclibot
[Release] Update index.json for extension [ communication ] (Azure#4304)
6b20f68 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1284075

Last commit: Azure@72de9b7
@Incarnation-p-lee
[Spring Cloud] Add buildpack-binding command for Enterprise tier. (Az…
f549964 
…ure#4302)

* [Spring-Cloud] Add buildpack-binding command for Enterprise tier.

* Add create, show, set, delete and list for buildpack-binding.
* Add enable app insights when create Enterprise tier.

Signed-off-by: Pan Li <[email protected]>

* Minor change.

Signed-off-by: Pan Li <[email protected]>

* format.

Signed-off-by: Pan Li <[email protected]>

* Make linter happy.

Signed-off-by: Pan Li <[email protected]>

* Reset help.py.

Signed-off-by: Pan Li <[email protected]>

* Re-add help.py

Signed-off-by: Pan Li <[email protected]>

* Add EOF.

Signed-off-by: Pan Li <[email protected]>

* Add UT for create enterprise tier with app insights.

Signed-off-by: Pan Li <[email protected]>

* Add record test for buildpack bindings.

Signed-off-by: Pan Li <[email protected]>

* Resolve comments.

Signed-off-by: Pan Li <[email protected]>

* Resolve comments.

Signed-off-by: Pan Li <[email protected]>

* Resolve comments and make static check happy.

Signed-off-by: Pan Li <[email protected]>

* Make static check happy.

Signed-off-by: Pan Li <[email protected]>

* Resolve comments.

Signed-off-by: Pan Li <[email protected]>

* Resolve comments.

Signed-off-by: Pan Li <[email protected]>

* Replace CRLF to LF.

Signed-off-by: Pan Li <[email protected]>

* Minor change format.

Signed-off-by: Pan Li <[email protected]>

* Make static check happy.

Signed-off-by: Pan Li <[email protected]>

* Merge parmas.

Signed-off-by: Pan Li <[email protected]>
@StrawnSC
Static Webapp Azure Frontdoor Integration (enterprise edge) (Azure#3959)
5b0c34b 
* add enterprise-edge extension

* add SKU validation

* remove 'az staticwebapp enterprise-edge wait'

* fix style/linter issues

* add provider validation

* update summary

* fix package data

* fix CODEOWNERS

* add static webapps to service_name

* add swa docs URL notification and help text

* remove out of date TODO

* fix typo

* handle lack of JSON response from server when enabling/disabling the CDN

* Fix style
@ninpan-ms @yuwzho
[Spring Cloud] Integrate tanzu components with service and app (Azure…
44ce91b 
…#4300)

* resolve conflict

* Update config_file_patterns None

Co-authored-by: Yuwei Zhou <[email protected]>

* Update kwargs

Co-authored-by: Yuwei Zhou <[email protected]>

* Update kwargs

Co-authored-by: Yuwei Zhou <[email protected]>

* linter check

* fix test

* Add test

* Add validate for parameters

* fix

* fix test

* fix

* fix comment

* fix test

* Add warning when clear patterns

* fix transformer

* fix type of properties

* fix lint

Co-authored-by: Yuwei Zhou <[email protected]>
@azclibot
[Release] Update index.json for extension [ enterprise-edge ] (Azure#…
2c2be60 
…4310)

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1286501

Last commit: Azure@5b0c34b
@yuwzho
fix(spring-cloud): 🐛 App update warns when active deployment not found (
ec35a6e 
Azure#4308)

* fix: 🐛 App update warns when  active deployment not found

* fix lint

* upgrade parameter

* fix comment

* fix lint

* fix lint
@evelyn-ys
[storage-preview] az storage account create/update: Support `--enab…
18eb1da 
…le-sftp` and `--enable-local-user` (Azure#4140)

* Bump `azure-mgmt-storage` to 2021-08-01

* linter

* update SDK

* Update SDK

* Copy `az storage account create/update` from CLI main repo

* `az storage account create/update`: Support `--enable-sftp` and `--enable-local-user`

* update sdk

* fix test

* re-record test
@smile37773 @yuwzho @zhoxing-ms
[Spring-Cloud] add Build Service related command for enterprise tier (A…
7f111bb 
…zure#4295)

* [Spring-Cloud] Add Build service for enterprise tier

* fix

* fix

* Update src/spring-cloud/azext_spring_cloud/_params.py

Co-authored-by: Yuwei Zhou <[email protected]>

* Update src/spring-cloud/azext_spring_cloud/_params.py

Co-authored-by: Yuwei Zhou <[email protected]>

* fix

* fix

* fix

* fix

* fix

* Update src/spring-cloud/azext_spring_cloud/_buildservices.py

Co-authored-by: Yuwei Zhou <[email protected]>

* Update src/spring-cloud/azext_spring_cloud/_buildservices.py

Co-authored-by: Yuwei Zhou <[email protected]>

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* Update src/spring-cloud/azext_spring_cloud/_params.py

Co-authored-by: Xing Zhou <[email protected]>

* Update src/spring-cloud/azext_spring_cloud/_params.py

Co-authored-by: Xing Zhou <[email protected]>

* fix

* add delete test

* fix

* Update spring_cloud_instance.py

* Update commands.py

* fix

* fix

* Update _params.py

* fix

* fix test

* fix test

* fix test

Co-authored-by: Yuwei Zhou <[email protected]>
Co-authored-by: Xing Zhou <[email protected]>
@vivek-microsoft @vivek67
Rename Ldap Parameter Names. (Azure#4315)
21473cb 
* managed cassandra commands for cli extension

* remove node-status, add backups

* fix style and add backup command

* AuthenticationMethod param

* add sku, availability and idenitty parameters

* bugfix

* add backup key uri

* python vendor sdk changes

* bugfix

* recorded scenario tests

* bugfix on cassandra_stop_start

* update invoke-command arguments

* bugfix

* conditionally set ldap properties

* ldap property bugfix

* linter fix

* linter fix

* remove public commands from preview

* linter fix in help text

* linter fix

* use backup show and backup list

* preview python sdk

* bugfix

* removing whitespace

* Update History.rst

* update setup.py

* rename parameters

* parameter rename and help text

* update version history

Co-authored-by: Vivek Sundararajan <[email protected]>
@calvinhzy @evelyn-ys
[Storage] az storage account local-user: add new command group loca…
350baa0 
…l-user with create, update, delete, list, show, list-key, and regenerate-password (Azure#4125)

* Bump `azure-mgmt-storage` to 2021-08-01

* linter

* update SDK

* start create_local_user

* continue create_local_user base64 error

* local user commands done, test pending

* test

* add help

* add help, fix credscan

* lint

* credscan

* credscan

* add back files deleted by accident

* Update _configuration.py

* refactor

* version

* lint

* add delete test

* fix PR comments

* lint, credscan

* date before release

* show command

Co-authored-by: [email protected] <[email protected]>
@evelyn-ys
[storage-preview] az storage account create/update: Support `--sam-…
224c7ee 
…account-name` and `--account-type` (Azure#4316)

* Bump `azure-mgmt-storage` to 2021-08-01

* linter

* update SDK

* Update SDK

* Copy `az storage account create/update` from CLI main repo

* `az storage account create/update`: Support `--enable-sftp` and `--enable-local-user`

* update sdk

* fix test

* re-record test

* `az storage account create/update`: Support `--sam-account-name` and `--account-type`

* add test
@vivek-microsoft @vivek67
Update workaround information in parameter helptext (Azure#4321)
68fd2df 
* update workaround information in helptext

* update setup.py to use 0.12.0 version

Co-authored-by: Vivek Sundararajan <[email protected]>
azclibot and others added 27 commits February 28, 2022 22:10
@azclibot
[Release] Update index.json for extension [ spring-cloud ] (Azure#4467)
8ad2928 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1393299

Last commit: Azure@47fd457
@zhoxing-ms @azclibot
[Release] Update index.json for extension [ appservice-kube ] (Azure#…
3a1af00 
…4481)

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1386720

Last commit: Azure@4fbcd8f

Co-authored-by: Azure CLI Team <[email protected]>
@swells
chore(arcdata): arcdata version bump to 1.2.2 (Azure#4473)
66f3092 
* chore(arcdata): arcdata version bump to 1.2.2

* chore(arcdata): arcdata version bump to 1.2.2
@ricardo-espinoza
Update version and history info for az quantum extension 0.13.0 (Azur…
f659327 
…e#4484)
@saisankargochhayat
Added ArcAppliance 0.2.16 (Azure#4487)
b4c3e63 
Co-authored-by: Sai Sankar Gochhayat <[email protected]>
@azclibot
[Release] Update index.json for extension [ quantum ] (Azure#4489)
f4a846d 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1408510

Last commit: Azure@f659327
@ZengTaoxu
{Quota}Generate quota with codegen (Azure#4475)
d292d6d 
* {Quota}Generate quota with codegen

* Update setup.py

* Update test_quota_crud.yaml

* Update test_quota_crud.yaml

* Update

* Update

* Update _help.py

* Update _help.py
@azclibot
[Release] Update index.json for extension [ quota ] (Azure#4496)
de5a6a4 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1412890

Last commit: Azure@d292d6d
[Quantum] Show progress messages and dots before executing commands (A…
65f4668 
…zure#4480)

* Show the first progress indicator dot before starting ARM template deployment

* Show progress messages on 'execute' and 'job submit'

* Change f-string to simple string
@swells
chore(arcdata): arcdata version bump to 1.2.3 (Azure#4501)
c45ca81
@kairu-ms
Revert "chore(arcdata): arcdata version bump to 1.2.3 (Azure#4501)" (A…
9caafc3 
…zure#4502)

This reverts commit c45ca81.
@swells
chore(arcdata): arcdata version bump to 1.2.3 (Azure#4503)
ba67bed
@StrawnSC
[appservice-kube] Make compatible with new SDK (Azure#4494)
f77b373 
* fix plan create and webapp create

* bump version, include bug fix from Azure#4493, fix style, fix webapp update bug, add basic regression tests

* remove deprecated 'az webapp update' params
@malachma @wangzelin007
Fix UUID issue for data disk (Azure#4479)
b68739c 
* new version 0.4.2

* new version 0.4.2

* Fixed an UUID issue by getting the data disk attached to the VM after VM creation

* Fixed an UUID issue by getting the data disk attached to the VM after VM creation

* Fixed an UUID issue by getting the data disk attached to the VM after VM creation

* Fixed an UUID issue by getting the data disk attached to the VM after VM creation

* Fixed an UUID issue by getting the data disk attached to the VM after VM creation

* Fixed an UUID issue by getting the data disk attached to the VM after VM creation

* Update src/vm-repair/azext_vm_repair/custom.py

Co-authored-by: ZelinWang <[email protected]>

Co-authored-by: ZelinWang <[email protected]>
@Arkanayan
Move cli to production subscription (Azure#4505)
cf52632
@ZengTaoxu
{NetworkManager}Add new commands (Azure#4413)
03dc817 
* {NetworkManager}Add new commands

Add new commands 'az network manager connection', 'az network manager connection management-group', 'az network manager scope connection', 'az network manager group static-members'

* Update _help.py

* Update _params.py

Bump up azure-mamt-network SDK to 2021_05_01_preview and Update  params and commands.

* Update

* Update

* Update

* Update

* Update

* Update

* update tests for new api version 2021-05-01-preview for network-manager extension

* Update

* Update

* Update custom.py

* Update

* Update

Co-authored-by: Jared Gorthy <[email protected]>
@ajparule @evelyn-ys
CosmosDB Adding enable MaterializedViews parameter for create/update …
387d57b 
…database … (Azure#4499)

* Adding enable MaterializedViews parameter for create/update database account

* api-version=2021-11-15-preview

* CassandraEnableMaterializedViews

* Update src/cosmosdb-preview/HISTORY.rst

Co-authored-by: Yishi Wang <[email protected]>

* Update src/cosmosdb-preview/README.md

Co-authored-by: Yishi Wang <[email protected]>

* Update src/cosmosdb-preview/azext_cosmosdb_preview/_params.py

Co-authored-by: Yishi Wang <[email protected]>

* Update linter_exclusions.yml

Co-authored-by: Yishi Wang <[email protected]>
@azclibot
[Release] Update index.json for extension [ network-manager ] (Azure#…
beb9a0d 
…4511)

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1419833

Last commit: Azure@03dc817
@azclibot
[Release] Update index.json for extension [ vm-repair ] (Azure#4507)
013e2a2 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1416685

Last commit: Azure@b68739c
@azclibot
[Release] Update index.json for extension [ appservice-kube ] (Azure#…
7181bb7 
…4504)

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1415742

Last commit: Azure@f77b373
@FumingZhang
{AKS} Fix several test cases (Azure#4506)
7ff0923 
* update

* update recording

* update subnet cidr for ingress test case

* update recordings

* fix coverage
@azclibot
[Release] Update index.json for extension [ cosmosdb-preview ] (Azure…
17164cb 
…#4512)

Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1419899

Last commit: Azure@387d57b
@vthiebaut10
SSH Extension v.1.0.1 (Azure#4474)
4e4b9c2
@vthiebaut10
Change how private ips are appended to the list (Azure#4517)
55eee43
@azclibot
[Release] Update index.json for extension [ ssh ] (Azure#4520)
2ce2a17 
Triggered by Azure CLI Extensions Release Pipeline - ADO_BUILD_ID=1426796

Last commit: Azure@55eee43
@jonathan-innis
Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …
b34977b 
…into k8s-extension/public
@jonathan-innis
Merge branch 'k8s-extension/public' into release/merge-private
dbb6acc
@jonathan-innis jonathan-innis merged this pull request into k8s-extension/private Mar 11, 2022
shubham1172 pushed a commit to shubham1172/azure-cli-extensions that referenced this pull request Oct 25, 2023
@sunnycarter @jddarby
@PerfectChaos @jordlay @patrykkulik-microsoft @Jamieparsons @jamiedparsons @Cyclam @wbradley94 @zhoxing-ms
Add aosm extension (Azure#6426)
638f562 
* removed deploy with sdk

* added artifact list

* push example cnf bicep

* Add temporary build workflow for AOSM extension (AzureArcForKubernetes#4)

* Add temporary build workflow for AOSM extension

* Add Releaser to maintain a release with the latest build in a consistent place

* added output dir; fixing getchartmappingschema

* Add empty init files to inner modules so setuptools recognises them as modules

* Use latest RG model to remove unnecessary dependency on version

* Use latest deployment model to remove unnecessary dependency on version

* fixed parameter mappings + copied needed files to output folder

* jinja2 and find value paths

* fixed typos + self.aritfacts only has unique artifacts

* use regex instead of string to find deploy params

* delete accidentaly commited input.json

* fixed deploy params; added indent to mapping file

* Update readme with install/bug reporting instructions

* Adjust headers so rendered readme looks nicer

* renamed values.nondef + added cli errors

* Split help command example lines

* Clarify that bug process is internal

* fixed parameter vals not updating

* delete unuseed temoplate and update jinja2 templates

* Update README.md

* Update README.md

* added docstrings; added basic error catching with file handling

* small refactor of generate nfd

* fixed j2 template captions; added create_nfd to cnf; edited error messages; added deleting existing folder to custom.py

* fixed file not found erroe

* Refactor commands to az aosm nfd|nsd build (AzureArcForKubernetes#10)

* Refactor commands to az aosm nfd|nsd build

* setup.py version

* Version was wrong

* remove publish option from build

* lint

* wrong params

* fixed most style errors; ran static checks and azdev style

* pre merge commit

* more style changes; renamed vnfbicepnfd to vnfnfd

* Update readme with workflow

* added configfile validation

* added temp dir to vnf; renamed shared constants

* sunny markups

* removed create_nfd_folder; added schema prefix to constant

* added deploymentparams to constants.py

* added error catching for get chart name and version

* added meaningful logs; prevent auto overwriting input.json

* edited vnf schema to have accepted types

* added templates to setup.py

* added location from input file not resourceGroup().location

* added path_to_mappings to input.json; added logic to take mappings from file outside of helm package

* renamed non_def_values to mappings_path

* Pk5/add nsd cli (AzureArcForKubernetes#15)

* First working version of the CLI NSD create

* Fully working version of the NSD CLI

* minor change to nsd_generate

* Sunny's refactor

* First round of cleanup

* Secound Round of cleanup

* fix the 2023 api NSDV

* description updates

* deleted comment

* Fix SNS creation

* Fix SNS creation try 2

* markups

* delete unnecessary file

* Testing markups

* Fix the SNS attempt 3

* minor fixes

* Fix config validation

* fix CNF depends on

* initial commit; ran python static checks fmt (except on vendored sdks), fixed styling on _configuration.py

* Name uploaded VHD correctly

* Self review markups

* broken config generation code

* fixed up configuration.py

* fixed cnf generator styling

* fixed styling for cnf generator

* fixed up nfd generator base and deploy with arm

* fixed styling for artifact.py

* fixed styling for atrifact manifest .py

* Code review markups

* fixed more linting

* first attempt at regex

* Sunny/choose deploy parameters (AzureArcForKubernetes#23)

* choose-deploy-parameters

* optioned deployParameters for CNF

* lint

* lint2

* docs

* docs

* lint

* 9.82 score

* Fix bugs

* more useful debug logs

* Fix bugs and logging

* lint

* markups

* Fix for oras target string with erroneous spaces

* fixed regex; tested on existing charts and sas charts; committing to not lose prints for testing

* changed regex constants + tidied

* fixed blankspace

* markups

* initial commit

* tidied code and added comments

* add multi nf config

* Add style and lint check

* added logic for handling deployparams within lists

* one line fix from review

* removing print statement

* added new test file and one unit test

* added workflow for unit tests in pipeline + set up rough structure of unit testing

* instantiated cnf class; added fake invalid helm package; added new files to use for testing

* Nsd for cnfs (AzureArcForKubernetes#33)

* NSD building for CNFs

* linting

* Add Publish command to the CNF azure CLI (AzureArcForKubernetes#24)

* Working publish

* Fix the artifact upload

* Working image copy

* minor fix

* Minor fixes

* sunny merge add-aosm-extension into patryk's branch (AzureArcForKubernetes#25)

* Sunny/choose deploy parameters (AzureArcForKubernetes#23)

* choose-deploy-parameters

* optioned deployParameters for CNF

* lint

* lint2

* docs

* docs

* lint

* 9.82 score

* Fix bugs

* more useful debug logs

* Fix bugs and logging

* lint

* markups

* comment out breaking line

* minor TODOs

* deleted comment

* fix bring your own parameters

* Markups

* Fix the helm upload

* Minor markups

* Change error message

---------

Co-authored-by: sunnycarter <[email protected]>
Co-authored-by: Sunny Carter <[email protected]>

* Expose NFD version and managed identities (AzureArcForKubernetes#34)

* NFDV version exposed as a CGV on an SNS

* Managed identities support on NFs

* Fix identiy, fix API versions

* history

---------

Co-authored-by: Jamie Parsons <[email protected]>
Co-authored-by: Sunny Carter <[email protected]>

* Add a first VNF test

* achurchard/style fixes (AzureArcForKubernetes#35)

Fix style issues raised by `azdev style`

* Add CNF UTs that will fail at the moment

* Actually include all files.

* Always run tests

* Add another test that won't pass yet

* remove github pipeline tests - they should run in Azure

* Sundry fixes for CNF quickstart (AzureArcForKubernetes#38)

* Sundry fixes for CNF quickstart

* merge add-aosm-ext in (AzureArcForKubernetes#37)

* markups

* NSD UTs

* Update read me.

* Improve path handling, other small refactorings (AzureArcForKubernetes#39)

# Main changes

## Make methods relying on self._tmp_dir private
- `self._tmp_dir` is only available in the context of calling `generate_nfd()`, so methods relying on `self._tmp_dir` should be private

## Use pathlib.Path rather than os file operations
- Provides clearer and stronger typing than passing `str`s around
- Adds some handy utility functions

## Variable renaming for clarity
- E.g. consistently use 'directory' / 'dir' (rather than mix with 'folder')
- Obvs somewhat subjective, but as someone new to most of this code, the changes made sense to me

## Add nfd_bicep_path as abstract property on NFDGenerator
- We rely on it when calling the concrete implementations
- Also use ABC rather than raise NotImplementedError

## Miscellaneous style updates to keep `azdev style aosm` happy
- isort
- black

* Fix Artifact upload on Windows (AzureArcForKubernetes#40)

* Black

* Mark ups

* Sunny/fix artifact upload windows (AzureArcForKubernetes#41)

* Fix Artifact upload on Windows

* mypy fixups

* mypy fixes

* linting

* mypy

* mypy for _configuration.py

* mypy for vnf_nfd_generator.py

* mypy appeasement

* python-static-checks fmt

* az style happy

* lint

* mypy cnf_nfd_generator

* copyright

* more lint

* Remove windows oras workaround now 0.0.18 oras out

* history

---------

Co-authored-by: Jamie Parsons <[email protected]>

* Fix VNFD build (AzureArcForKubernetes#42)

* Multiple instances of the same NF

* fix vnf deploy schema types (AzureArcForKubernetes#44)

* Tidy up

* Mypy and docs

* history.rst

* Update README with logging info (AzureArcForKubernetes#43)

* Update README with logging info

* Update docs

* self markups

* Take oras 0.1.19 to fix Windows artifact upload (AzureArcForKubernetes#46)

* Rename a few things

* DRY the deploy_nfd_from_bicep code

* Make conditional statements clearer

* black

* Update custom.py to use new nfd deploy method

* Black with text processing

* Create new nfRET class

* Mypy passing

* UTs passing

* Dry the deploy_nfd_from_bicep() code (AzureArcForKubernetes#48)

- Removed duplicated code in the deploy_vnfd_from_bicep() and deploy_cnfd_from_bicep() methods
- Moved variables onto the class instance and stopped passing them around in the method signatures
  - Also made the deployer class a dataclass for cleaner __init__
- Made parameters a property of the class, and moved the logic for getting/generating them into that property method
- Improved the typing
  - Included adding enums for SkipSteps and DeployableResourceTypes
- Added the new skip step logic for image uploads
  - Added a new skip step type of IMAGE_UPLOAD

Testing:
- No MyPy errors
- Live tests for VNFS+NSD, CNFs, including all --skip options

* Unit tests added

* Versions are wrong in NSD template comments

* Self review markups

* Remove wrong comments

* Code review markups

* Extra markups

* Fix mypy

* Pk5/add integration tests (AzureArcForKubernetes#51)

* Somewhat working example

* Cleanups

* Update recording

* fix minor linting error

* More markups

* Update output in tests

* Pk5/minor integration tests changes (AzureArcForKubernetes#52)

* Modify changelog and rename tests

* Delete recording file

* Update recordings

* Update developer docs

* Remove credentials

* Fix linting

* cheeky extra change

* Remove credentials from the integration test recordings (AzureArcForKubernetes#54)

* Modify changelog and rename tests

* Delete recording file

* Fix the credentials issue in the integration tests

* Update CHANGELOG

* Markups

* Fix typo

* Minor markups

* Make cleaning up resources more robust and remove the VHD external reference

* Markups

* Remove the integration test from the repo (AzureArcForKubernetes#56)

* prerequisite docker for cnf

* Fix bicep render on Windows (AzureArcForKubernetes#57)

* Fixes for Windows (AzureArcForKubernetes#58)

* Fix bicep render on Windows

* Fixes for Windows

* python-static-checks ran

* ADO-880627: Use docker-less ACR login

For running in environments without docker, such as CI pipelines.
This affects uploading Helm charts for CNFs - the ACR login now fetches
an access token, which is used to login to the Helm registry and upload
the chart.

* docker is not required any more

* Remove pre-release build and lint files from release branch (AzureArcForKubernetes#63)

* Release markups - release branch (AzureArcForKubernetes#65)

* Markups from release comments

* history

* markups and fixes

* README changes

* linting fixes

* Fix integration tests (AzureArcForKubernetes#67)

* Fix integration tests

* Update src/aosm/development.md

Co-authored-by: Cyclam <[email protected]>

* Update src/aosm/azext_aosm/tests/latest/test_aosm_cnf_publish_and_delete.py

Co-authored-by: Cyclam <[email protected]>

* Update src/aosm/azext_aosm/tests/latest/test_aosm_cnf_publish_and_delete.py

Co-authored-by: Cyclam <[email protected]>

* Markup changes

---------

Co-authored-by: Cyclam <[email protected]>
Co-authored-by: Sunny Carter <[email protected]>

* Add aosm to service_name.json

* move artifact upload to before nfd/nsd deploy (AzureArcForKubernetes#62)

* move artifact upload to before nfd/nsd deploy

* markups

* check in new test recording

* non-working attempt to use token creds

* Check for Azure features on deploy and delete (AzureArcForKubernetes#71)

* WIP: Check for features on deploy and delete

* linting

* Anand has confirmed names of flags

* Update test recording as now has calls to Features API

* Update src/aosm/azext_aosm/custom.py

Co-authored-by: jamiedparsons <[email protected]>

* docstring markups

---------

Co-authored-by: jamiedparsons <[email protected]>

* code working

* Fix generate-config

* Fix tests

* lint

* linting

* Jl/nfdv proxy (AzureArcForKubernetes#73)

* added publisher scope to input file; changed to proxy nsdv

* fixed get request on proxy nfdv (should be overwritten when autogenerated again)

* small print bug fix

---------

Co-authored-by: Jordan <[email protected]>

* Code review mark ups

* Linting and fix UTs

* aosm codeowner

* Update HISTORY.rst

* Normalise aosm version to 1.0.0b1 for release

* update hashes in recording

* Temporary test revert of "aosm codeowner"

This reverts commit 479ba54.

* Fix license header formatting

* Revert "Temporary test revert of "aosm codeowner""

This reverts commit 0e4d0e7.

* Remove nonexistent entry from codeowners

* Fix source_local_docker_image defaults to placeholder text (AzureArcForKubernetes#79)

* temp fix for bug

* minor formatting

* refactor + change validation ordering to mimic previous behaviour

* add docstring

---------

Co-authored-by: Jordan <[email protected]>

* renamed nsdg to nsd

* Helptext + a little bit of validation

* Fixed up validation

* Return True if _all_ required artifact manifests exist, not just the last one checked.

* Code markups + linting.

* Docs: CNF publish options and permissions (AzureArcForKubernetes#91)

* Requirement for docker again

* revert bad markup (AzureArcForKubernetes#94)

* Move live tests to swedensouth

* Actually move to uaenorth

* Don't log out ACR passwords when artifact commands fail (AzureArcForKubernetes#97)

* Don't log out passwords when artifact commands fail

* Don't log out passwords when artifact commands fail part 2

* Comment to explain dropping the original exception

* Fix cnf image take 2 (AzureArcForKubernetes#101)

* Fix CNF image copy to work cross subscription

* Cross subscription works for image copy. Still test same subscription

* lint

* Error message

* oops, code paste error

* markups

* appease mypy

* Default RG and ACR Values with Publisher Name (AzureArcForKubernetes#103)

* added default rg and acr values for nf + nsd; added blob_url default for vnf

* added bug fix to close Paulo's bug

* change error message back

---------

Co-authored-by: Jordan <[email protected]>

* Fix unauthorized error bug

* Add spacing

* fix unexpected symbol when parsing lists (AzureArcForKubernetes#107)

* Validation requirements on helm names (AzureArcForKubernetes#109)

* Validation requirements on helm names

* lint

* markups

* lint

* Fix error parsing

* Lower case acr names (AzureArcForKubernetes#112)

* Lower case ACR names and fix interactive mode for lists

* lint

* remove duplicate else branch

* always allow azureDeployLocation to be configurable

* Add new optional VHD parameters

* Make VNF publish and delete a live test only

* Validate VHD parameters in build UT

* Markups from the CLI team

* mark-ups

* remove azureDeployLocation as a configurable vhd parameter

* add explanitory comments

* Updates for 2023-09-01 API (AzureArcForKubernetes#84)

* Regen Python SDK from 2023-09-01 API 
  - also uses latest AutoRest client
  - fix for HybridNetworkManagementClient init signature (swap order of subscription_id and credential parameters)

* Update CLI extension code to use new SDK

* added SAMI to publisher pre deploy

* Update bicep templates to use 2023-09-01

* Update NF templates

* Update metaschema

* Add Allow-Publisher to required feature flags

* Use secure objects for deployment parameters

* Correctly get array item types in CNF deployment parameter schemas

* Revert master .flake8 config

* Fix double space in user output.

Co-authored-by: Xing Zhou <[email protected]>

* Remove delete message to be consistent with other CLI extensions

* Move "Deleted <resource>" messages to logger.info().

* Remove Blob_SAS_URL Option from ArmTemplate in input file (AzureArcForKubernetes#119)

* moved blob url to vhd config only; untested

* stopped error in post innit before validate

* changed ordering of inputs so that blob and filepath are next to each other; helptext for filepath different for each option

* Markups from sunny

* appease mypy

---------

Co-authored-by: Jordan <[email protected]>
Co-authored-by: Sunny Carter <[email protected]>

---------

Co-authored-by: Jordan <[email protected]>
Co-authored-by: Jacob Darby <[email protected]>
Co-authored-by: Chaos <[email protected]>
Co-authored-by: Chaos Chhapi <[email protected]>
Co-authored-by: jordlay <[email protected]>
Co-authored-by: patrykkulik-microsoft <[email protected]>
Co-authored-by: Jacob <[email protected]>
Co-authored-by: Jamie Parsons <[email protected]>
Co-authored-by: jamiedparsons <[email protected]>
Co-authored-by: Andy Churchard <[email protected]>
Co-authored-by: Cyclam <[email protected]>
Co-authored-by: William Bradley <[email protected]>
Co-authored-by: Xing Zhou <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NarayanThiru NarayanThiru Awaiting requested review from NarayanThiru NarayanThiru is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.