-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[k8s-extension] Release v1.0.4 with SSL secret support for AzureML #4286
[k8s-extension] Release v1.0.4 with SSL secret support for AzureML #4286
Conversation
[pull] release from Azure:master
…into k8s-extension/public-preview
* Update sdks with updated swagger spec * Update version and history rst * Reorder release history timeline * Fix ExtensionInstanceForCreate for import
…into k8s-extension/public
…es/azure-cli-extensions into k8s-extension/public
* populate configuration protected settings for azureml bump version && add log fetch connection string only if configuration protected settings are set update ssl key * bump the version * reverse changes on version and HISTORY.rst * inferenceLoadBalancerHA Co-authored-by: Yue Yu <[email protected]>
* Unparallelize tests * Moved location of pipeline file * Remove the parallel invoke expression calls * Add templates to testing
Co-authored-by: Yue Yu <[email protected]> Co-authored-by: Jonathan Innis <[email protected]>
…into k8s-extension/public
* Add one more prompt for amlarc extension update * fix pylint issue * fix pylint issue * fix pylint issue * fix pylint issue Co-authored-by: Youhua Tu <[email protected]> Co-authored-by: Youhua Tu <[email protected]>
* Update appliance API to latest version for identity * Create a utils file with get parent_api_version * Fix style errors
…into k8s-extension/public
…es/azure-cli-extensions into k8s-extension/public
…into k8s-extension/public
* support sslSecret * fix * fix error message Co-authored-by: Jun Min <[email protected]>
…into k8s-extension/public
k8s-extension |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask you to add some tests for this release?
Hi @wangzelin007. We have E2E tests that we run in our fork that are not merged into upstream. We are unable to do unit testing because our extension resource relies on pre-created resources in Azure (i.e. a connectedCluster resource) |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.