Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Implement --enable-oidc-issuer #4280

Merged
merged 9 commits into from
Jan 4, 2022
Merged

Conversation

bcho
Copy link
Member

@bcho bcho commented Dec 30, 2021


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 30, 2021

AKS

@bcho bcho changed the title [WIP] [AKS] Implement --enable-oidc-issuer [AKS] Implement --enable-oidc-issuer Dec 31, 2021
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@bcho
Copy link
Member Author

bcho commented Jan 4, 2022

hey @yonzhan @zhoxing-ms could you please take a look and merge this pr? Thanks!

@zhoxing-ms zhoxing-ms merged commit c721194 into Azure:main Jan 4, 2022
@bcho bcho deleted the aks-enable-oidc branch January 4, 2022 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants