Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[connectedvmware] Added tags support and fix know bugs. #4264

Merged
merged 8 commits into from
Jan 4, 2022
Merged

[connectedvmware] Added tags support and fix know bugs. #4264

merged 8 commits into from
Jan 4, 2022

Conversation

iamsantoshmishra
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 28, 2021

connectedvmware

@zhoxing-ms
Copy link
Contributor

zhoxing-ms commented Dec 29, 2021

In order to solve the following CI issues, I migrated azure_devtools.scenario_tests to azure.cli.testsdk.scenario_tests according to the practice of #4211

======================================================================
ERROR: azext_connectedvmware.tests.latest.test_arcvmware_scenario (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: azext_connectedvmware.tests.latest.test_arcvmware_scenario
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/vsts/work/1/s/src/connectedvmware/azext_connectedvmware/tests/latest/test_arcvmware_scenario.py", line 9, in <module>
    from azure_devtools.scenario_tests import AllowLargeResponse
ModuleNotFoundError: No module named 'azure_devtools'


======================================================================
ERROR: azext_connectedvmware.tests.latest.test_connectedvmware_scenario (unittest.loader._FailedTest)
----------------------------------------------------------------------
ImportError: Failed to import test module: azext_connectedvmware.tests.latest.test_connectedvmware_scenario
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/unittest/loader.py", line 436, in _find_test_path
    module = self._get_module_from_name(name)
  File "/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/unittest/loader.py", line 377, in _get_module_from_name
    __import__(name)
  File "/home/vsts/work/1/s/src/connectedvmware/azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py", line 9, in <module>
    from azure_devtools.scenario_tests import AllowLargeResponse
ModuleNotFoundError: No module named 'azure_devtools'

@yonzhan yonzhan requested a review from jsntcy December 29, 2021 15:13
@zhoxing-ms
Copy link
Contributor

Please re-run this test test_connectedvmware in live mode and re-record the yaml file for this test to fix the CI issue

@zhoxing-ms zhoxing-ms merged commit 3bcc340 into Azure:main Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants