Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spring-cloud): 🐛 App update warns when active deployment not found #4308

Merged
merged 7 commits into from
Jan 12, 2022

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Jan 11, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Previously wrongly fatal the az spring-cloud app update when there is no active deployment under it. It should just set a warning if user just want to update the app properties

Will upgrade version in #4294

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 11, 2022

spring-cloud

@zhoxing-ms zhoxing-ms merged commit ec35a6e into Azure:main Jan 12, 2022
@yuwzho yuwzho deleted the yuwzho/update-warning branch January 12, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants