Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring-Cloud] refactor spring-cloud create #4291

Merged
merged 4 commits into from
Jan 5, 2022

Conversation

yuwzho
Copy link
Contributor

@yuwzho yuwzho commented Jan 4, 2022


This PR refactors the logic in az spring-cloud create. In previous implementation, it was major implemented by if/else switches. If Enterprise goes to one place else to another.
This change uses template to divide the creation into before/creating/after phases. Every tier implementations can define its own steps.

This PR will bumb up versions with other PRs together in #4294

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 4, 2022

Spring-Cloud

@zhoxing-ms zhoxing-ms merged commit 07d4ad5 into Azure:main Jan 5, 2022
@yuwzho yuwzho deleted the yuwzho/spring-cloud-create-refactor branch January 5, 2022 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants