-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick CI improvements to release branch #8743
Conversation
ci: schedule nightly test against Endo master
ci(restore-node): properly use `context.eventName` in script
ci: send test failure notifications when not a PR
ci: properly handle subdependencies for Endo branch override
ci(restore-node): avoid clobbering `#endo-branch:` setup
ci(restore-node): detect staged yarn.lock, package.json
…t-test-deps ci(deployment): only install ansible and terraform if not available
Restore duplicate checks
ci: combine integration tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was added due to codeowners on SECURITY.md
, it has the recent fix, so approving. At a glance everything else looks good too.
I expect the last few commits to change (the fixups in particular) once Agoric/agoric-3-proposals#58 has landed and a new version of |
d88e33e
to
8ab37f3
Compare
This is now ready for final review. To measure against the goal of catching up the GH Actions workflows, you can use https://github.com/Agoric/agoric-sdk/compare/master..mhofman/update-release-ci to compare |
8ab37f3
to
897f51b
Compare
897f51b
to
26d198b
Compare
I plan on adding #8760 to the cherry-picks once it lands |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To measure against the goal of catching up the GH Actions workflows, you can use https://github.com/Agoric/agoric-sdk/compare/master..mhofman/update-release-ci to compare
.github/
,a3p-integration/
and.mergify.yml
between this branch andmaster
The relevant directories do indeed align. Other changes do as well... affected files on the release side are still missing some changes such as those from #8205, but those are very disruptive and unnecessary here anyway. LGTM!
refs: #XXXX
Description
Cherry picks all commits necessary from master in order to bring CI in the release branch to parity.
Because some changes had already been partially picked, a decent amount of conflict resolution was necessary. A few changes were left behind as not applicable to the release branch.
Performed with the following rebase-todo:
Security Considerations
None
Scaling Considerations
None
Documentation Considerations
None
Testing Considerations
Yes! All CI tests should keep passing
Upgrade Considerations
This does now yet change any upgrade logic, but does update the upgrade integration tests to the latest and greatest